fix: Channel clamping logic in ChannelPools to respect configured channel bounds#12863
fix: Channel clamping logic in ChannelPools to respect configured channel bounds#12863lqiu96 wants to merge 4 commits intofeat/channelpool-resizingfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a configurable maxResizeDelta to the ChannelPoolSettings and implements a mechanism to log a warning when the channel pool undergoes repeated resizing cycles. It also includes several bug fixes related to channel count clamping and improves the internal logic for determining when a resize is necessary. The review feedback identifies a validation check for maxResizeDelta that is overly restrictive and could cause failures in valid configurations, such as small pools. Additionally, there is a concern regarding the thread safety of the consecutiveResizes counter, which is currently a primitive integer accessed outside of synchronized blocks.
|
|
2 participants
No description provided.