Conversation
sofisl
changed the title
Contributor
Author
pearigee
approved these changes
Mar 12, 2026
| } catch (e) { | ||
| console.error(`GCF_METADATA_CHECK: error=${e.message}`); | ||
| } | ||
| })(); |
There was a problem hiding this comment.
(optional) Do we want to await this? Will the following code fail if the metadata isn't available? At the very least, it may guarantee the log message appears in a consistent place during execution.
| opts: {strip?: number; filter?: (file: any) => boolean}, | ||
| callback: (err?: Error | null) => void, | ||
| ) => { | ||
| const output = Math.floor(Math.random() * 1000000) + '.zip'; |
There was a problem hiding this comment.
(optional) Any reason not to use randomUUID for stuff like this?
| console.log(`Downloading ${input} to ${output}...`); | ||
|
|
||
| const writeStream = fs.createWriteStream(output); | ||
| const stream = (got as unknown as got.Got).stream(input); |
There was a problem hiding this comment.
(optional) Does got not have types? Could we just install @types/got for added safety?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.