-
Notifications
You must be signed in to change notification settings - Fork 22
chore: fix multiple failing tests on main #920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
64 commits
Select commit
Hold shift + click to select a range
efc994a
chore: update go to 1.25
sofisl 434d4b8
chore: pin nock and return kaniko project executor to previous state
sofisl 3dbff4c
update ingress settings
sofisl d173f6e
chore: fix syncpack and try to fix issue with glcoud deployment
sofisl 5c88e19
specify syncpack
sofisl abbd5eb
remove syncpack check
sofisl fb2e32a
Remove 'only' from cloud functions test suite
sofisl 740b8c6
re-add syncpack
sofisl 3eaaae2
revert all the package.json fixes
sofisl 9f01780
chore: revert all the package.jsons
sofisl 06da790
chore: update nock
sofisl cced820
revert changes to syncpack
sofisl bdee41e
run lint
sofisl 8bb2e1f
Increase timeout for system tests
sofisl 566da68
chore: only test
sofisl e96b7e2
update gcx
sofisl aa3152c
retry
sofisl 09fd126
retry
sofisl e064662
retry
sofisl 519186c
chore: get url dynamically
sofisl b77c157
add bucket
sofisl 3f3fc20
retry
sofisl 0680423
rerun tests
sofisl 016e7d0
retry
sofisl 8664bcc
remove bucket name
sofisl 6446ef8
chore: add fixes for gcp metadata
sofisl a0a91e4
Increase timeout for system tests
sofisl c694556
test: replace gcx with gcloud CLI in system tests to avoid 403 Forbidden
sofisl 108a59c
chore: remove unused gcx dependency
sofisl 31959d2
ci: fix gcloud path in Dockerfile
sofisl 1331d05
ci: improve gcloud install and add python symlink in Dockerfile
sofisl 4ca24d1
test: add defensive logging for gcloud path in system tests
sofisl e0a5ca9
ignore tests while in dev
sofisl 678c129
update cloudbuild
sofisl a1c8d0e
retry
sofisl 35b20a5
retry yaml
sofisl d176538
retry
sofisl 1f033f5
retry
sofisl 6f926eb
rerun system tests
sofisl 175e34c
chore: cleanup PR
sofisl 0fb4a2f
chore: revert package.json
sofisl bbe0df5
retry cloudbuild credentials
sofisl 0b0e017
run tests
sofisl 1a0a2a7
run tests
sofisl 828d2e5
chore: retry
sofisl 7fb6caf
chore: fix unit and sytsem tests
sofisl be22cf6
run tests
sofisl fd00d90
run tests
sofisl 1c45c49
chore: fix system tests
sofisl a3140ab
retry issue with cloudbuild yaml
sofisl ac905cf
retry reverting gapic showcase issues
sofisl aa8edd4
revert all showcase changes
sofisl 86cc0f9
revert gapic showcase
sofisl bc0257a
fix system tests
sofisl bad37dc
chore: fix triggers
sofisl cf7dc3b
revert changs to showcase server
sofisl 9a7aaf2
update go version
sofisl fe44188
Update cloudbuild.yaml
sofisl 41247c3
Update cloudbuild.yaml
sofisl a6e03bf
update cloudbuild.yaml
sofisl aabb79e
update cloudbuild to build dockerfile
sofisl ea8b098
run lint
sofisl b53c57e
revert changes to prepublish
sofisl bf6804d
explicitly await hook
sofisl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 1 addition & 16 deletions
17
packages/gcp-metadata/system-test/fixtures/hook/.gcloudignore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,4 @@ | ||
| # This file specifies files that are *not* uploaded to Google Cloud Platform | ||
| # using gcloud. It follows the same syntax as .gitignore, with the addition of | ||
| # "#!include" directives (which insert the entries of the given .gitignore-style | ||
| # file at that point). | ||
| # | ||
| # For more information, run: | ||
| # $ gcloud topic gcloudignore | ||
| # | ||
| .gcloudignore | ||
| # If you would like to upload your .git directory, .gitignore file or files | ||
| # from your .gitignore file, remove the corresponding line | ||
| # below: | ||
| node_modules | ||
| .git | ||
| .gitignore | ||
|
|
||
| node_modules | ||
| #!include:.gitignore | ||
|
|
||
| test/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(optional) Do we want to
awaitthis? Will the following code fail if the metadata isn't available? At the very least, it may guarantee the log message appears in a consistent place during execution.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done!