Repository navigation
Let the agent choose the channels it uploads - #186
Merged
Merged
Conversation
gpufl trace --upload and gpufl upload pinned the agent to device,scope,system,sass. The agent is becoming a channel-agnostic transport that uploads every channel with published windows, so other producers (such as the serving writer) need no launcher change, and the launcher should not carry their channel names. - TraceArgs::log_types is now empty by default and gpufl upload passes no list. --log-types still narrows a trace upload. - With an empty list the agent starts without GPUFL_LOG_TYPES: an inherited value is removed, so the agent's own default applies. The agent never took the list as an argument. - gpufl monitor still passes system. Uploads do not change: native sessions hold only those four channels, every released agent defaults to the same four, and an older launcher's list acts as a filter on a newer agent.
The table still listed device,scope,system. With a channel-agnostic agent, an unset GPUFL_LOG_TYPES means every channel it finds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The launcher no longer pins the channels its gpufl-agent uploads.
gpufl trace --uploadandgpufl uploadused to passdevice,scope,system,sassexplicitly, so any other producer's channel in the output folder (for example theservingchannel the Python gpufl-serving writer uses) was never uploaded by a launcher-started agent. gpufl-client now carries no producer's channel names: with no--log-types, the agent decides, and from gpu-flight/gpufl-agent#31 on it uploads every channel that has published windows with sidecars.TraceArgs::log_typesis empty by default;--log-typesstill passes the user's list.gpufl uploadno longer hard-codes the list (it has no--log-typesoption).GPUFL_LOG_TYPESfrom the environment the agent inherits, so a value exported in the parent shell cannot narrow it.daemon/README.mddescribes the agent's new default.gpufl monitoris unchanged (it passessystem).Compatibility:
Type of Change
Testing
gpufl_tests, launcher and agent suites: 159 of 159 pass. New:AgentEnvironmentTest.AnEmptyChannelListRemovesAnInheritedFilter(a probe child sees an exportedGPUFL_LOG_TYPES, and no longer sees it after an empty list is applied);CliParseTrace.UploadFlagnow expects an empty default;UploadAgentFlagsstill keeps an explicit list.unsetEnv(::unsetenv) and the POSIX branches of the new test's helpers.Checklist