core,opentelemetry: Fix server metric labels on early close#12774
Open
becomeStar wants to merge 2 commits intogrpc:masterfrom
Open
core,opentelemetry: Fix server metric labels on early close#12774becomeStar wants to merge 2 commits intogrpc:masterfrom
becomeStar wants to merge 2 commits intogrpc:masterfrom
Conversation
Resolve generated-method classification before serverCallStarted() so close metrics do not fall back to "other" when streamClosed() happens first. Keep fallback registry lookup on the existing async path and avoid tracer-side HandlerRegistry access to match the maintainer constraints from issue grpc#12117. Add regressions for primary generated, primary non-generated, and fallback-generated server paths, plus the tracer-level early-resolution contract.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses the server-side OpenTelemetry metric labeling bug from #12117 where a generated method can be recorded as
grpc.method="other"ifstreamClosed()happens beforeserverCallStarted().What changed
StatsTraceContext.ServerCallMethodListenerhook so tracers can consume an already-resolved primary-registryMethodDescriptorMethodLookuppath runsWhy this shape
HandlerRegistrylookupTests
otherserverCallMethodResolved()+streamClosed()records the generated method name without waiting forserverCallStarted()Notes
ServerCallMethodListeneris an internal hook that carries the resolvedMethodDescriptor; tracers consume the resolved result instead of performing registry lookup themselvesServerImplusesInternalHandlerRegistryexplicitly for the primary registry to make it clear that the early transport- path lookup is limited to the immutable internal primary registryRef #12117