Repository navigation
Conversation
yiyixuxu
reviewed
Oct 26, 2026
| optional_parameters = {param.name for param in blocks.inputs if param.name is not None and not param.required} | ||
| assert self.optional_params <= optional_parameters, self.optional_params - optional_parameters | ||
|
|
||
| def test_pipeline_required_inputs(self): |
Collaborator
There was a problem hiding this comment.
ohh i think it's related to this #15009
thanks for writing them
i'm working on a PR for that, i can merge the test into my branch once PR is up
Member
Author
There was a problem hiding this comment.
Sure, please feel free to merge this branch directly into yours. Closing the PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two new tests related to #14521.
With these tests, on
mainand onrequired-input-no-defaultboth, we run into (same) failures:main: https://pastebin.com/3Lg7Zxnwrequired-input-no-default: https://pastebin.com/asfBEZymMarking the PR draft for now until we decide how to proceed.