targets: add commented CAN bus pins to 7 H7 targets#11631
Open
daijoubu wants to merge 1 commit into
Open
Conversation
Add commented-out CAN1 pin definitions to AETH743Basic, BROTHERHOBBYH743, CORVON743V1, DAKEFPVH743PRO, MICOAIR743, TBS_LUCID_H7, and TBS_LUCID_H7_WING. Pins sourced from the corresponding ArduPilot hwdef files. Blocks are commented by default so normal builds are unaffected; users with CAN-capable hardware can uncomment to enable DroneCAN support via a custom build. CORVON743V1 and MICOAIR743 use PB8/PB9 (no standby pin in AP hwdef). DAKEFPVH743PRO uses PD2 as standby (differs from the usual PD3). Remaining five use PD0/PD1/PD3.
Contributor
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
Test firmware build ready — commit Download firmware for PR #11631 238 targets built. Find your board's
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds commented-out CAN1 pin definitions to 7 H7 flight controller targets where CAN bus pins could be identified from the corresponding ArduPilot hwdef files.
Targets updated:
Important: Definitions are commented out
These pin definitions are sourced from ArduPilot hwdef files and have not been validated on real hardware. We do not have any of these boards available for testing. The blocks are commented out by default so normal builds are completely unaffected.
The FDCAN1 peripheral can only be used as an alternate function on a limited number of pins, so the pin assignments are easy to audit.
STM32H743 has 2 FDCAN peripherals (FDCAN3 is only on H725/H730 variants — the H743 CMSIS header confirms IS_FDCAN_ALL_INSTANCE covers only FDCAN1+FDCAN2).
Both use AF9. From RM and Datasheet:
Users who have the hardware and want to test DroneCAN can uncomment the block in their local target.h and do a custom build. Confirmed working INAV DroneCAN targets (KAKUTEH7WING, MATEKH743, MATEKF765) served as the pattern reference.
What was checked before adding
What was excluded and why
Build matrix
All targets pass, zero warnings.