Unify invalid-keyword error message across constructors - #184
Merged
Conversation
_parse_init_args used a hardcoded 'this function' message, while the vectorcall path reported the type name, so PyPy (which goes through tp_init) showed a different error than CPython. Use the same format and pass the qualified type name (e.g. 'xxhash.xxh32') to _parse_init_args, which also fixes 'multiple values' and 'too many positional' messages on the tp_init path.
Contributor
Merging this PR will not alter performance
Comparing 
Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make constructor error messages consistent across interpreters. The vectorcall path (CPython) reported
'bad' is an invalid keyword argument for 'xxhash.xxh32()', but_parse_init_args(used bytp_init, e.g. PyPy) used a hardcoded'... for this function'message.Changes
src/_xxhash.c:_parse_init_argsnow uses the same'%U' is an invalid keyword argument for '%s()'format and receives the qualified type name (e.g.xxhash.xxh32) instead of__init__()multiple values for argument ...andtakes at most 2 positional argumentsmessages on thetp_initpath to name the type instead of__init__()4.0.0.dev6Testing
xxh32(bad=1)andxxh32.__init__(h, bad=1))