Skip to content

Unify invalid-keyword error message across constructors #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ifduyue merged 2 commits into from
Aug 12, 2026
+9 −8
Merged

Unify invalid-keyword error message across constructors #184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c49cfdc
Unify invalid-keyword error message across constructors
ifduyue Aug 12, 2026
f01b08b
Bump version to 4.0.0.dev6
ifduyue Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions src/_xxhash.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -741,7 +741,8 @@ _parse_init_args(PyObject *args, PyObject *kwargs,
PyUnicode_CompareWithASCIIString(key, "seed") == 0)
continue;
PyErr_Format(PyExc_TypeError,
"'%U' is an invalid keyword argument for this function", key);
"'%U' is an invalid keyword argument for '%s()'",
key, funcname);
return -1;
}
}
Expand Down Expand Up @@ -789,7 +790,7 @@ _parse_init_args(PyObject *args, PyObject *kwargs,
}

/* Macro to generate __init__ for each hash type. */
#define XXHASH_INIT(type, reset_fn, update_fn, seed_cast) \
#define XXHASH_INIT(type, name, reset_fn, update_fn, seed_cast) \
static int PY##type##_init(PY##type##Object *self, PyObject *args, \
PyObject *kwargs) \
{ \
Expand All @@ -798,7 +799,7 @@ static int PY##type##_init(PY##type##Object *self, PyObject *args, \
Py_buffer buf = {NULL, NULL}; \
\
if (_parse_init_args(args, kwargs, &data_obj, &seed_val, \
"__init__()") < 0) \
name) < 0) \
return -1; \
\
if (data_obj) { \
Expand All @@ -818,7 +819,7 @@ static int PY##type##_init(PY##type##Object *self, PyObject *args, \
return 0; \
}

XXHASH_INIT(XXH32, XXH32_reset, XXH32_update, XXH32_hash_t)
XXHASH_INIT(XXH32, "xxhash.xxh32", XXH32_reset, XXH32_update, XXH32_hash_t)

PyDoc_STRVAR(
PYXXH32_update_doc,
Expand Down Expand Up @@ -1169,7 +1170,7 @@ static PyObject *PYXXH64_new(PyTypeObject *type, PyObject *args, PyObject *kwarg
return (PyObject *)self;
}

XXHASH_INIT(XXH64, XXH64_reset, XXH64_update, XXH64_hash_t)
XXHASH_INIT(XXH64, "xxhash.xxh64", XXH64_reset, XXH64_update, XXH64_hash_t)

PyDoc_STRVAR(
PYXXH64_update_doc,
Expand Down Expand Up @@ -1520,7 +1521,7 @@ static PyObject *PYXXH3_64_new(PyTypeObject *type, PyObject *args, PyObject *kwa
return (PyObject *)self;
}

XXHASH_INIT(XXH3_64, XXH3_64bits_reset_withSeed, XXH3_64bits_update, XXH64_hash_t)
XXHASH_INIT(XXH3_64, "xxhash.xxh3_64", XXH3_64bits_reset_withSeed, XXH3_64bits_update, XXH64_hash_t)

PyDoc_STRVAR(
PYXXH3_64_update_doc,
Expand Down Expand Up @@ -1878,7 +1879,7 @@ static PyObject *PYXXH3_128_new(PyTypeObject *type, PyObject *args, PyObject *kw
return (PyObject *)self;
}

XXHASH_INIT(XXH3_128, XXH3_128bits_reset_withSeed, XXH3_128bits_update, XXH64_hash_t)
XXHASH_INIT(XXH3_128, "xxhash.xxh3_128", XXH3_128bits_reset_withSeed, XXH3_128bits_update, XXH64_hash_t)

PyDoc_STRVAR(
PYXXH3_128_update_doc,
Expand Down
2 changes: 1 addition & 1 deletion xxhash/version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
VERSION = "4.0.0.dev5"
VERSION = "4.0.0.dev6"
Loading