Skip to content

chore: sync package scripts and fix lint errors in tests#164

Merged
joshjohanning merged 2 commits intomainfrom
update-package-json-scripts
Mar 29, 2026
Merged

chore: sync package scripts and fix lint errors in tests#164
joshjohanning merged 2 commits intomainfrom
update-package-json-scripts

Conversation

@joshjohanning
Copy link
Copy Markdown
Owner

@joshjohanning joshjohanning commented Mar 29, 2026

Summary

Syncs package.json scripts to match the standard template used across other actions in this repo, and fixes two ESLint quote errors in the test file.

Changes

package.json

  • Renamed formatformat:write to match standard script naming convention
  • Renamed test:coverageci-test (now includes bash tests + Jest coverage)
  • Removed separate test:js script (inlined into test and ci-test)
  • Updated lint to use npx eslint . instead of npx eslint src/**/*.js
  • Synced package script argument order
  • Added bundle script (format:write + package)
  • Added package:watch script
  • Updated all script to use new script names

__tests__/index.test.js

  • Converted two double-quoted strings containing single quotes to template literals to satisfy ESLint quotes rule

Copilot AI review requested due to automatic review settings March 29, 2026 15:03
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aligns the project’s npm scripts with a shared Node.js Action template and resolves ESLint quotes rule failures in Jest tests.

Changes:

  • Updated package.json scripts (rename/add scripts, adjust lint scope, consolidate Jest invocation with NODE_OPTIONS).
  • Fixed two ESLint quote-rule violations in __tests__/index.test.js by switching to template literals.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
package.json Syncs scripts (format/lint/test/package/all) to the standard template and adds bundle / package:watch.
tests/index.test.js Adjusts string literals to satisfy ESLint quotes rule.

@joshjohanning joshjohanning merged commit 40500cb into main Mar 29, 2026
8 checks passed
@joshjohanning joshjohanning deleted the update-package-json-scripts branch March 29, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants