Skip to content

chore: sync package scripts and fix lint errors in tests #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshjohanning merged 2 commits into from
Mar 29, 2026
+12 −11
Merged

chore: sync package scripts and fix lint errors in tests #164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91dc639
chore: update package.json scripts for consistency
joshjohanning Mar 29, 2026
34e25a1
chore(tests): update linting error
joshjohanning Mar 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions __tests__/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ describe('Azure DevOps Commit Validator', () => {
await run();

expect(mockSetFailed).toHaveBeenCalledWith(
"At least one of 'check-commits' or 'check-pull-request' must be set to true. Both are currently set to false."
`At least one of 'check-commits' or 'check-pull-request' must be set to true. Both are currently set to false.`
);
});

Expand Down Expand Up @@ -775,7 +775,7 @@ describe('Azure DevOps Commit Validator', () => {
await run();

expect(mockWarning).toHaveBeenCalledWith(
expect.stringContaining("Invalid value 'invalid-value' for 'pull-request-check-scope'")
expect.stringContaining(`Invalid value 'invalid-value' for 'pull-request-check-scope'`)
);
// Should still pass because it falls back to title-or-body and title has AB#
expect(mockSetFailed).not.toHaveBeenCalled();
Expand Down
19 changes: 10 additions & 9 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,17 +9,18 @@
},
"main": "dist/index.js",
"scripts": {
"format": "npx prettier --write .",
"bundle": "npm run format:write && npm run package",
"ci-test": "npm run test:bash && NODE_OPTIONS='--experimental-vm-modules' npx jest --coverage",
"coverage": "npx @joshjohanning/make-coverage-badge-better --label-color '#333' --output-path ./badges/coverage.svg",
"format:write": "npx prettier --write .",
"format:check": "npx prettier --check .",
"lint": "npx eslint src/**/*.js",
"test": "npm run test:bash && npm run test:js",
"lint": "npx eslint .",
"package": "npx @vercel/ncc build src/index.js -o dist --source-map --license licenses.txt",
"package:watch": "npm run package -- --watch",
"test": "npm run test:bash && NODE_OPTIONS='--experimental-vm-modules' npx jest",
"test:bash": "./__tests__/action.test.sh",
"test:js": "NODE_OPTIONS=--experimental-vm-modules npx jest",
"test:watch": "NODE_OPTIONS=--experimental-vm-modules npx jest --watch",
"test:coverage": "NODE_OPTIONS=--experimental-vm-modules npx jest --coverage",
"coverage": "npx @joshjohanning/make-coverage-badge-better --label-color '#333' --output-path ./badges/coverage.svg",
"package": "npx @vercel/ncc build --source-map --license licenses.txt src/index.js -o dist",
"all": "npm run format && npm run lint && npm run test:coverage && npm run coverage && npm run package"
"test:watch": "NODE_OPTIONS='--experimental-vm-modules' npx jest --watch",
"all": "npm run format:write && npm run lint && npm run ci-test && npm run coverage && npm run package"
},
"repository": {
"type": "git",
Expand Down
Loading