release: 1.5.0, and publish release notes from the CHANGELOG - #32
Merged
Conversation
Cuts 1.5.0 with the three user-visible changes since v1.4.0: the PDF viewer loading on demand, the fuller icon canvas, and the trash failure that was being recorded as a successful toss. Also fixes why every release so far has had an empty body. electron-builder creates the GitHub release itself and never sets one, so v0.9.0 through v1.4.0 all published with no notes. The release job now fills it from the matching CHANGELOG section via scripts/changelog-section.js. A prerelease tag has no section of its own, so a miss leaves the notes untouched instead of failing a release that has already uploaded its artifacts. The internal work since v1.4.0 — the preload fix, the smoke test, the module extractions — is deliberately not in the changelog: none of it changed anything for someone running v1.4.0, and the preload regression never reached a release. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cuts 1.5.0 and fixes the reason every release so far has had an empty body.
What's in 1.5.0
Three user-visible changes since v1.4.0:
Changed
Fixed
useFileSessionextraction, which only commits the "deleted" transition oncemoveToTrashresolves.Why the version is 1.5.0
Every release in this project has been a minor bump, including v1.4.0 — which was two
fix(...)commits. Following that convention rather than introducing a patch-release pattern here.Empty release notes
electron-builder creates the GitHub release itself and never sets a body, so v0.9.0 through v1.4.0 all published with no notes at all. The release job now fills it from the matching CHANGELOG section:
A prerelease tag (
v1.3.0-rc.1) has no section of its own, so a miss logs and moves on rather than failing a release that has already uploaded its artifacts. The job already exportsGH_TOKEN, so no new secret is needed.Extraction verified locally against 1.5.0, an older section (1.2.0), and a missing version (exits 1).
Not in the changelog
The preload fix, the smoke test and the module extractions since v1.4.0 are deliberately left out — none of it changed anything for someone running v1.4.0, and the preload regression never reached a release. Listing it would imply their install was broken.
🤖 Generated with Claude Code