fix: error on empty Study Root to prevent silent recording failure#140
Open
sappelhoff wants to merge 1 commit intolabstreaminglayer:masterfrom
Open
fix: error on empty Study Root to prevent silent recording failure#140sappelhoff wants to merge 1 commit intolabstreaminglayer:masterfrom
sappelhoff wants to merge 1 commit intolabstreaminglayer:masterfrom
Conversation
Author
|
cc @cboulay |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can reproduce the issue through this "setting" and trying to record a file:
... it will not be saved, see also:
--> hence, here a test that study_root is actually filled in.
We lost some data like this, unfortunately, so with this PR I'd like to prevent such accidents in the future 🙂