Skip to content

fix: error on empty Study Root to prevent silent recording failure #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cboulay merged 1 commit into from
Apr 1, 2026
+8 −2
Merged

fix: error on empty Study Root to prevent silent recording failure #140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/mainwindow.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ void MainWindow::load_config(QString filename) {
// StorageLocation
QString studyRoot;
legacyTemplate.clear();

if (pt.contains("StorageLocation")) {
if (pt.contains("StudyRoot"))
throw std::runtime_error("StorageLocation cannot be used if StudyRoot is also specified.");
Expand Down Expand Up @@ -400,6 +400,12 @@ void MainWindow::startRecording() {
QMessageBox::critical(this, "Filename empty", "Can not record without a file name");
return;
}
if (ui->rootEdit->text().trimmed().isEmpty()) {
QMessageBox::critical(this, "Study Root empty",
"Can not record without a Study Root folder. "
"Please set a Study Root before recording.");
return;
}
recFilename.prepend(QDir::cleanPath(ui->rootEdit->text()) + '/');

QFileInfo recFileInfo(recFilename);
Expand Down Expand Up @@ -431,7 +437,7 @@ void MainWindow::startRecording() {
". Please check your permissions.");
return;
}

std::vector<std::string> watchfor;
for (const QString &missing : std::as_const(missingStreams)) {
std::string query;
Expand Down
Loading