Skip to content

fix(web): name prompt generator action - #40328

Merged
lyzno1 merged 1 commit into
mainfrom
codex/a11y-prompt-generator-action
Aug 10, 2026
Merged

fix(web): name prompt generator action#40328
lyzno1 merged 1 commit into
mainfrom
codex/a11y-prompt-generator-action

Conversation

@lyzno1

@lyzno1 lyzno1 commented Aug 9, 2026

Copy link
Copy Markdown
Member

Summary

  • give the workflow prompt generator action a localized accessible name
  • hide the generator glyph from the accessibility tree
  • add a behavior test that finds the real ActionButton by name and opens the generator dialog

Ownership and scope

PromptGeneratorBtn owns the action and the transition that opens GetAutomaticResModal. The test keeps the ActionButton and state transition real while mocking the modal and workflow store as external boundaries. Prompt generation requests, modal contents, editor values, and shared primitives are unchanged.

Visual regression review

This is an ARIA-only production change. The rendered ActionButton, classes, dimensions, glyph, color, and click path are unchanged.

Please verify:

  • 16px generator glyph shape, primary color, and alignment
  • ActionButton box geometry
  • hover, active, and focus-visible states
  • no shift in the surrounding prompt editor controls

Validation

  • regression proof: the new semantic test failed against the unnamed baseline
  • focused Vitest: 1/1 passed after the fix
  • standalone accessibility lint: 0 findings
  • focused format/lint/type check: 0 errors, 1 existing icon warning
  • full pnpm check: 0 errors, 2059 existing warnings
  • git diff --check: passed

Rollback

Revert this PR alone to remove the accessible name and its behavior test. Prompt generation behavior and modal implementation are unaffected.

@github-actions github-actions Bot added the web This relates to changes on the web. label Aug 9, 2026
@lyzno1 lyzno1 changed the title codex/a11y prompt generator action fix(web): name prompt generator action Aug 9, 2026
@codecov

codecov Bot commented Aug 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.43%. Comparing base (7522ae1) to head (e764625).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #40328      +/-   ##
==========================================
- Coverage   86.47%   86.43%   -0.04%     
==========================================
  Files        5264     5107     -157     
  Lines      294867   290742    -4125     
  Branches    59029    57924    -1105     
==========================================
- Hits       254976   251304    -3672     
+ Misses      34950    34497     -453     
  Partials     4941     4941              
Flag Coverage Δ
cli ?
dify-ui 93.49% <ø> (ø)
web 86.12% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lyzno1
lyzno1 marked this pull request as ready for review August 9, 2026 15:47
@lyzno1
lyzno1 requested review from iamjoel and zxhlyh as code owners August 9, 2026 15:47
@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Aug 9, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Aug 10, 2026
@lyzno1
lyzno1 added this pull request to the merge queue Aug 10, 2026
Merged via the queue into main with commit 83987b8 Aug 10, 2026
42 of 43 checks passed
@lyzno1
lyzno1 deleted the codex/a11y-prompt-generator-action branch August 10, 2026 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants