Skip to content

refactor(web): use css icon for prompt generator - #40329

Closed
lyzno1 wants to merge 1 commit into
codex/a11y-prompt-generator-actionfrom
codex/refactor-prompt-generator-icon
Closed

refactor(web): use css icon for prompt generator#40329
lyzno1 wants to merge 1 commit into
codex/a11y-prompt-generator-actionfrom
codex/refactor-prompt-generator-icon

Conversation

@lyzno1

@lyzno1 lyzno1 commented Aug 9, 2026

Copy link
Copy Markdown
Member

Summary

  • replace the prompt generator SVG component with the equivalent CSS icon span
  • keep the glyph decorative and preserve its 16px size and primary color
  • remove exactly one prefer-tailwind-icons warning

Dependency

This PR is stacked on #40328 because it preserves the named generator action and its behavior test. It contains only the icon implementation change.

Visual regression review

Please compare before and after:

  • generator glyph shape and 16px dimensions
  • primary color in light and dark themes
  • inline alignment and ActionButton box geometry
  • hover, active, and focus-visible states
  • surrounding prompt editor layout

No text, event, accessible name, modal state, or component geometry is intentionally changed.

Validation

  • focused Vitest: 1/1 passed
  • standalone accessibility lint: 0 findings
  • focused format/lint/type check: 0 findings
  • full pnpm check: 0 errors, 2058 existing warnings
  • warning delta from parent: exactly -1
  • git diff --check: passed

Rollback

Revert this PR alone to restore the SVG component. The semantic fix and behavior test in #40328 remain intact.

@github-actions github-actions Bot added the web This relates to changes on the web. label Aug 9, 2026
@lyzno1

lyzno1 commented Aug 9, 2026

Copy link
Copy Markdown
Member Author

Closing during the accessibility stack audit. This layer only changes component typing or icon implementation, adds no user-visible accessibility contract, and carries independent visual/review risk. It can be reconsidered later as a separate cleanup, not as an a11y dependency.

@lyzno1 lyzno1 closed this Aug 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant