Skip to content

fix(web): name assigner add operation - #40337

Merged
lyzno1 merged 1 commit into
mainfrom
codex/a11y-assigner-add-operation
Aug 10, 2026
Merged

fix(web): name assigner add operation#40337
lyzno1 merged 1 commit into
mainfrom
codex/a11y-assigner-add-operation

Conversation

@lyzno1

@lyzno1 lyzno1 commented Aug 9, 2026

Copy link
Copy Markdown
Member

Summary

  • give the existing assigner Add action its localized accessible name
  • hide the glyph from the accessibility tree
  • replace the positional test query with role and name

Review boundary

Form submission, validation, fields, event handling, elements, classes, and layout are unchanged.

Verification

  • owner suite: 1/1 passed
  • standalone a11y lint: 0 diagnostics
  • full static check: 0 errors
  • diff check: passed

Visual regression and dependency

Production changes are ARIA-only, so normal pixels remain identical. This is an independent root layer; former icon and typing cleanup children are closed.

@github-actions github-actions Bot added the web This relates to changes on the web. label Aug 9, 2026
@lyzno1 lyzno1 changed the title codex/a11y assigner add operation fix(web): name assigner add operation Aug 9, 2026
@codecov

codecov Bot commented Aug 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.43%. Comparing base (7522ae1) to head (48aae30).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #40337      +/-   ##
==========================================
- Coverage   86.47%   86.43%   -0.05%     
==========================================
  Files        5264     5107     -157     
  Lines      294867   290741    -4126     
  Branches    59029    57924    -1105     
==========================================
- Hits       254976   251290    -3686     
+ Misses      34950    34510     -440     
  Partials     4941     4941              
Flag Coverage Δ
cli ?
dify-ui 93.49% <ø> (ø)
web 86.11% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lyzno1
lyzno1 marked this pull request as ready for review August 9, 2026 15:47
@lyzno1
lyzno1 requested review from iamjoel and zxhlyh as code owners August 9, 2026 15:47
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 9, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Aug 10, 2026
@lyzno1
lyzno1 added this pull request to the merge queue Aug 10, 2026
Merged via the queue into main with commit 1017a76 Aug 10, 2026
58 of 71 checks passed
@lyzno1
lyzno1 deleted the codex/a11y-assigner-add-operation branch August 10, 2026 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants