Skip to content

refactor(web): use css icon for assigner add - #40338

Closed
lyzno1 wants to merge 1 commit into
codex/a11y-assigner-add-operationfrom
codex/refactor-assigner-add-icon
Closed

refactor(web): use css icon for assigner add#40338
lyzno1 wants to merge 1 commit into
codex/a11y-assigner-add-operationfrom
codex/refactor-assigner-add-icon

Conversation

@lyzno1

@lyzno1 lyzno1 commented Aug 9, 2026

Copy link
Copy Markdown
Member

Summary

  • replace the single decorative Remix add glyph with its matching CSS icon
  • preserve the exact 16px size, shrink behavior, and tertiary text color
  • remove the now-unused icon import

Boundary

This is an owner-local visual-resource cleanup only. The accessible name remains owned by #40337, and the React component typing cleanup remains in the next PR.

Validation

  • focused lint — the one icon-component warning is removed
  • pnpm --dir web exec vp test run app/components/workflow/nodes/assigner/__tests__/panel.spec.tsx — 1 passed
  • pnpm --dir web lint:a11y app/components/workflow/nodes/assigner/panel.tsx — passed
  • pnpm check — 0 errors, 2058 warnings (exactly one fewer)
  • git diff --check — passed

Visual regression review

Compare the add glyph shape, 16px bounds, tertiary color, centering, shrink behavior, button box, and hover/active/light/dark states. No visual difference is intended; any mismatch is a regression.

Stack

Depends on #40337. Second PR in stack #40340.

@github-actions github-actions Bot added the web This relates to changes on the web. label Aug 9, 2026
@lyzno1

lyzno1 commented Aug 9, 2026

Copy link
Copy Markdown
Member Author

Closing during the accessibility stack audit. This layer only changes component typing or icon implementation, adds no user-visible accessibility contract, and carries independent visual/review risk. It can be reconsidered later as a separate cleanup, not as an a11y dependency.

@lyzno1 lyzno1 closed this Aug 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant