refactor(web): rely on preview dialog containment - #40363
Open
lyzno1 wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #40363 +/- ##
==========================================
- Coverage 86.47% 86.43% -0.04%
==========================================
Files 5264 5107 -157
Lines 294867 290736 -4131
Branches 59029 57924 -1105
==========================================
- Hits 254976 251289 -3687
+ Misses 34950 34506 -444
Partials 4941 4941
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
lyzno1
marked this pull request as ready for review
August 9, 2026 15:47
lyzno1
requested review from
CodingOnStar,
hyoban,
iamjoel and
zxhlyh
as code owners
August 9, 2026 15:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Review boundary
DOM nodes, classes, media controls, drag, zoom, hotkeys, close behavior, portals, and Dialog configuration are unchanged. Audio and video caption debt and the separate image drag baseline remain out of scope.
Visual regression review
There is no element, class, style, or rendering diff. No new visual state is introduced.
Verification
Dependency and rollback
Independent root layer; the former PDF icon child is closed.