Skip to content

refactor(web): rely on preview dialog containment - #40363

Open
lyzno1 wants to merge 2 commits into
mainfrom
codex/refactor-preview-dialog-containment
Open

refactor(web): rely on preview dialog containment#40363
lyzno1 wants to merge 2 commits into
mainfrom
codex/refactor-preview-dialog-containment

Conversation

@lyzno1

@lyzno1 lyzno1 commented Aug 9, 2026

Copy link
Copy Markdown
Member

Summary

  • remove redundant click-propagation handlers from image, audio, video, and PDF preview content
  • rely on Dify UI Dialog disablePointerDismissal for pointer containment
  • click real preview content in tests and verify dialogs stay open
  • remove seven suppressions owned only by those handlers

Review boundary

DOM nodes, classes, media controls, drag, zoom, hotkeys, close behavior, portals, and Dialog configuration are unchanged. Audio and video caption debt and the separate image drag baseline remain out of scope.

Visual regression review

There is no element, class, style, or rendering diff. No new visual state is introduced.

Verification

  • four focused suites: 42/42 passed
  • standalone a11y lint: 0 new diagnostics
  • full static check: 0 errors
  • suppression delta: -7
  • diff check: passed

Dependency and rollback

Independent root layer; the former PDF icon child is closed.

@lyzno1 lyzno1 changed the title codex/refactor preview dialog containment refactor(web): rely on preview dialog containment Aug 9, 2026
@github-actions github-actions Bot added the web This relates to changes on the web. label Aug 9, 2026
@codecov

codecov Bot commented Aug 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.43%. Comparing base (7522ae1) to head (d93c661).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #40363      +/-   ##
==========================================
- Coverage   86.47%   86.43%   -0.04%     
==========================================
  Files        5264     5107     -157     
  Lines      294867   290736    -4131     
  Branches    59029    57924    -1105     
==========================================
- Hits       254976   251289    -3687     
+ Misses      34950    34506     -444     
  Partials     4941     4941              
Flag Coverage Δ
cli ?
dify-ui 93.49% <ø> (ø)
web 86.11% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lyzno1
lyzno1 marked this pull request as ready for review August 9, 2026 15:47
@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. refactor labels Aug 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor size:XS This PR changes 0-9 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant