refactor(web): use css icons for PDF preview - #40364
Closed
lyzno1 wants to merge 1 commit into
Closed
Conversation
lyzno1
force-pushed
the
codex/refactor-pdf-preview-icons
branch
from
August 9, 2026 11:25
c8956f3 to
00aba9a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## codex/refactor-preview-dialog-containment #40364 +/- ##
==========================================================================
Coverage 86.43% 86.43%
==========================================================================
Files 5107 5107
Lines 290736 290736
Branches 57924 57924
==========================================================================
Hits 251289 251289
Misses 34506 34506
Partials 4941 4941
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
Closing during the accessibility stack audit. This layer only changes component typing or icon implementation, adds no user-visible accessibility contract, and carries independent visual/review risk. It can be reconsidered later as a separate cleanup, not as an a11y dependency. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aria-hiddenBoundary
Validation
pnpm --dir web exec vp test run app/components/base/file-uploader/__tests__/pdf-preview.spec.tsx— 10/10 passed./node_modules/.bin/vp lint web/app/components/base/file-uploader/pdf-preview.tsx web/app/components/base/file-uploader/__tests__/pdf-preview.spec.tsxpnpm --dir web lint:a11y app/components/base/file-uploader/pdf-preview.tsxpnpm check— 0 errors, 2056 warnings, exactly 3 fewer than the parentgit diff --checkVisual regression review
Stack
Rollback
Revert commit
00aba9a51ff7e123b9adc4802b4056f2dd646b7d; the parent containment cleanup remains intact.