fix: support model type alias parsing#157
Merged
Merged
Conversation
dosubot
Bot
added
the
size:M
This was referenced May 23, 2026
WH-2099
force-pushed
the
fix/model-type-alias-parsing
branch
from
ea275e9 to
53ed6d5
Compare
asukaminato0721
approved these changes
May 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ModelType._missing_Why
Some persisted or API-origin model type strings still use provider-native values such as
embeddings,text-generation, andreranking. LettingModelType(...)handle those aliases keeps enum parsing consistent across runtime and persistence paths.Validation
uv run pytest tests/model_runtime/test_model_dispatch.py tests/dsl/test_slim_package_loader.pymake tcCloses #21