Conversation
lookups._cut trims every read's text before the assistant sees it and had no test of its own. CutTests pins what it does: whitespace and newlines collapse below 600, a body keeps its lines at 600, a string exactly n long is not cut, a longer one ends with ' [...]', and None reads as ''. No behaviour change - the guard is the point (issue ldbumble#73).
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #73.
What changed
A new
CutTestsclass intests/test_lookups.pypinslookups._cut.Why
_cuttrims every look-up's text before the assistant reads it. It is pure, used everywhere, and had no test of its own.How
Six cases, covering the behaviour the issue names:
n < 600) collapses whitespace and newlines to single spaces;n >= 600) keeps its own lines;599collapses,600keeps;nlong is not cut;[…];Nonereads as''.Tests
Windows 11, Python 3.12.10.
No code change - the guard is the point.