Split the finder into its stages - #70
Merged
Komoszek merged 0 commit intoSep 22, 2026
Merged
Conversation
Komoszek
force-pushed
the
claude/issue-58-split-finder
branch
from
September 22, 2026 05:56
5c61666 to
bd0fa7e
Compare
Komoszek
force-pushed
the
claude/issue-58-transitive
branch
from
September 22, 2026 05:56
46be3f7 to
55c60ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #67; retarget to
mainonce it merges. #68 then lands on top of this, so the transitive rounds arrive as a change insidesettler.dartrather than a rewrite offinder.dart. A move, not a change: same tests (278), same--verbosenarration.Ciachwas ~1000 lines with five jobs. It now keeps the server session and the pipeline (discover → collect → fetch → settle), ~200 lines; each stage is a collaborator, in the patternRemoveSafety,OverrideRemovalsandCrossLibraryReferencesalready follow.candidate_collector.dartreference_fetch.dartSourceIndexsettler.dartverdict.dartCode moved verbatim except:
_toUnused→Verdict.finding,_byLocation→ top-levelcompareByLocation,_semanticTokensOrEmpty→ top-level (the collector and the fetch both need it), andSuperclassChecks/OverrideRemovalsare built once inSettler.settleinstead of inline.🤖 Generated with Claude Code
https://claude.ai/code/session_011fqaUyaQtY7AkuTYBjAUJv