feat: restore icon and context menu when Explorer restarts if necessary#71
Merged
lijy91 merged 5 commits intoleanflutter:mainfrom Apr 25, 2025
pzhlkj6612:feat/windows/explorer-taskbar-awareness
Merged
feat: restore icon and context menu when Explorer restarts if necessary#71lijy91 merged 5 commits intoleanflutter:mainfrom pzhlkj6612:feat/windows/explorer-taskbar-awareness
lijy91 merged 5 commits intoleanflutter:mainfrom
pzhlkj6612:feat/windows/explorer-taskbar-awareness
Conversation
- restore the icon with the existing resource. - do create pop-up menu only once.
Correct the message of the previous commit.
Contributor
Author
|
Sorry for being confusing. The title of this PR and the message of the key commit has been corrected: - feat: restore icon and context menu when Explorer restarts if possible
+ feat: restore icon and context menu when Explorer restarts if necessary
We should NOT take care of possibility, but necessity. |
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! I'm going to fix #65.
To maintainers
To preserve the hard work from @brandon3343, I've being based on #39. Please don't forget to squash all commits into one before merging.
Test
The screen recordings for comparison:
leanflutter-tray_manager-windows-taskbar-awareness-original.mp4
leanflutter-tray_manager-windows-taskbar-awareness-fixed.mp4
My test steps:
powershell -command "gps explorer | spps"), then check system tray.The environment:
.