fix: BOLT12 arm of UnifiedPayment::send returns DuplicatePayment/PersistenceFailed errors - #1098
Merged
tnull merged 1 commit intoSep 18, 2026
Conversation
|
I've assigned @tnull as a reviewer! |
Bartok9
force-pushed
the
fix/bolt12-duplicate-fallback-terminal-errors
branch
2 times, most recently
from
September 16, 2026 12:47
d7d9eb9 to
283800b
Compare
…istenceFailed errors The BOLT12 arm used .map_err() + if let Ok, so DuplicatePayment and PersistenceFailed fell through to BOLT11/onchain — risking double payment. Now treats both as terminal, mirroring the BOLT11 fix in lightningdevkit#1038. Fixes: lightningdevkit#1060 AI-assisted: generated by Sera (Hermes Agent), verified manually. Signed-off-by: Bartok9 <259807879+Bartok9@users.noreply.github.com>
Bartok9
force-pushed
the
fix/bolt12-duplicate-fallback-terminal-errors
branch
from
September 17, 2026 12:49
283800b to
3c98b1c
Compare
tnull
approved these changes
Sep 18, 2026
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BOLT12 arm of UnifiedPayment::send fell through to BOLT11/onchain on DuplicatePayment/PersistenceFailed — risks double payment. Mirrors BOLT11 fix (#1038).
Fixes #1060
AI-assisted: generated by Sera (Hermes Agent), verified manually.
Signed-off-by: Bartok9 259807879+Bartok9@users.noreply.github.com