feat: toggle git-server enabled on migration to external git

[merll]

Deactivates the git-server while migrating to an external Git source. This becomes effective after apl-operator reloads.

[Copilot]

Copilot review overview

🟡 Changes recommended

URL classification and default app enablement can incorrectly leave git-server enabled.

Review effort: Balanced
Findings: 2

Open (2)

• Use exact hostname matching for internal Git server URLs · New
• Treat omitted enabled as enabled during migration · New

What changed in this PR

Disables the internal git-server app when migrating to an external Git repository.

Changes:

• Disables git-server before committing and pushing the migration.
• Adds migration toggle assertions.

File	Description
src/​otomi-stack.ts	Adds git-server deactivation during external migration.
src/​otomi-stack.test.ts	Tests deactivation and non-migration paths.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Copilot review overview

🔵 Needs a closer look

URL classification and implicit app enablement can prevent the correct toggle behavior.

Review effort: Balanced
Findings: 2

Open (2)

• Treat omitted enabled as enabled during migration
• Use exact hostname matching for internal Git server URLs

[Copilot]

Copilot review overview

🔵 Needs a closer look

Internal repository detection uses unreliable substring matching.

Review effort: Balanced
Findings: None

Resolved since last review (2)

• Treat omitted enabled as enabled during migration
• Use exact hostname matching for internal Git server URLs

[Copilot]

Copilot review overview

🟢 Approval recommended

The implementation correctly persists the toggle before committing and adequately covers the affected migration paths.

Review effort: Balanced
Findings: None

[Copilot]

Copilot review overview

🟡 Changes recommended

saveAppToggle stores and writes different object shapes, causing inconsistent persisted state.

Review effort: Balanced
Findings: 1

Open (1)

• Persist normalized platformObject instead of the original app · New

Previously missed (1)

In code that hasn't changed since last review

Add regression coverage for internal Git migration

src/​otomi-stack.test.ts:1529

The new hostname branch is only exercised with external URLs. Add a migration case targeting GIT_DEFAULT_CONFIG.repoUrl (with a changed source repo/branch) and assert that get/saveAppToggle are not called; otherwise a regression that disables the internal Git server during an internal migration would go undetected.

[Copilot]

Copilot review overview

🟡 Changes recommended

Catalog responses can violate the API schema, and canonical internal Git URLs may incorrectly disable their own server.

Review effort: Balanced
Findings: 2

Open (2)

• Normalize trailing DNS dot before Git server hostname comparison · New
• Normalize catalog status in create and list responses · New

Resolved since last review (1)

• Persist normalized platformObject instead of the original app

[Copilot]

Copilot review overview

🟡 Changes recommended

Catalogs stored in memory can omit the required status field after creation or editing.

Review effort: Balanced
Findings: 2

Open (2)

• Preserve default status in in-memory catalog after create or edit · New
• Normalize catalog status in create and list responses

Resolved since last review (1)

• Normalize trailing DNS dot before Git server hostname comparison

[Copilot]

Copilot review overview

🔵 Needs a closer look

Catalog collection responses can omit required status data, and the prior repository-host classification concern remains unresolved.

Review effort: Balanced
Findings: 2

Open (2)

• Preserve default status in in-memory catalog after create or edit
• Normalize catalog status in create and list responses

[Copilot]

Copilot review overview

🟡 Changes recommended

The previously identified repository-host substring check remains unresolved.

Review effort: Balanced
Findings: None

Resolved since last review (2)

• Preserve default status in in-memory catalog after create or edit
• Normalize catalog status in create and list responses

[Copilot]

Copilot review overview

🟡 Changes recommended

Migration back to the internal Git server can leave its application disabled.

Review effort: Balanced
Findings: 1

Open (1)

• Restore git-server enabled state when migrating to internal URL · New

[Copilot]

Copilot review overview

🟡 Changes recommended

External-repository detection still uses unsafe substring matching, leaving the existing correctness issue unresolved.

Review effort: Balanced
Findings: 1

Open (1)

• Restore git-server enabled state when migrating to internal URL

[Copilot]

Copilot review overview

🟡 Changes recommended

The unresolved substring hostname check can misclassify external repositories and leave git-server enabled.

Review effort: Balanced
Findings: 1

Open (1)

• Restore git-server enabled state when migrating to internal URL