fix: secure repo url#989
Open
dennisvankekem wants to merge 2 commits into
Open
Conversation
9 tasks
j-zimnowoda
reviewed
May 11, 2026
j-zimnowoda
reviewed
May 11, 2026
j-zimnowoda
previously requested changes
May 11, 2026
ferruhcihan
requested changes
May 13, 2026
| repoUrl: | ||
| description: Path to a remote git repo without protocol. Will use https to access. | ||
| pattern: ^(.+@)*([\w\d\.]+)(:[\d]+){0,1}/*(.*)$ | ||
| pattern: '^(?:(?:https://)?[A-Za-z0-9.-]+\.[A-Za-z]{2,}|git@[A-Za-z0-9.-]+\.[A-Za-z]{2,}:)/[A-Za-z0-9_.-]+/[A-Za-z0-9_.-]+(?:\.git)?$' |
Collaborator
There was a problem hiding this comment.
This pattern does not work correctly for git@ SSH urls. The non-capturing group incorrectly ends at git@[...]:, causing the pattern to require a slash / that breaks standard SSH URLs like git@host:owner/repo.
| repoUrl: | ||
| description: Path to a remote git repo without protocol. Will use https to access. | ||
| pattern: ^(.+@)*([\w\d\.]+)(:[\d]+){0,1}/*(.*)$ | ||
| pattern: '^(?:(?:https://)?[A-Za-z0-9.-]+\.[A-Za-z]{2,}|git@[A-Za-z0-9.-]+\.[A-Za-z]{2,}:)/[A-Za-z0-9_.-]+/[A-Za-z0-9_.-]+(?:\.git)?$' |
Collaborator
There was a problem hiding this comment.
This pattern only supports two path segments, while normalizeRepoUrl (and the tests) handles three or more, which may cause issues with GitLab subgroups. (e.g., https://gitlab.example.com/platform/backend/my-repo)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
console: linode/apl-console#782
api: #989