Skip to content

fix: secured repo url#782

Open
dennisvankekem wants to merge 2 commits into
mainfrom
APL-1775
Open

fix: secured repo url#782
dennisvankekem wants to merge 2 commits into
mainfrom
APL-1775

Conversation

@dennisvankekem
Copy link
Copy Markdown
Collaborator

@dennisvankekem dennisvankekem commented May 11, 2026

console: #782
api: linode/apl-api#989

Considerations

  • I have tested the changes in both light and dark mode.
  • I have considered the need for new unit tests.
  • I have tested the changes on a cluster.
  • I have included relevant documentation updates.
  • I have an approved Figma design or have reflected my changes in Figma
  • I have verified that the UI/UX is consistent in major browsers (e.g., Chrome, Firefox, Safari, Edge).
  • I have tested the changes for responsiveness in different screen resolutions.
  • I have tested expected error states and verified that the user is presented with informative error messages.
  • I have tested the feature with unusual or extreme inputs (e.g., very long strings, empty states, clicking a button multiple times quickly).


const getSafeRepositoryHref = (repositoryUrl: string): string | null => {
if (!SAFE_REPO_URL.test(repositoryUrl)) return null
return `https://${repositoryUrl}`
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this line is causing an issue. Clicking the link redirects incorrectly due to the duplicated https:// prefix, and it may not work properly with SSH links either.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants