Repository navigation
router: drop stale RouterError from lm15.router.__all__ - #23
Open
harshitgavita-07 wants to merge 1 commit into
Open
harshitgavita-07 wants to merge 1 commit into
harshitgavita-07 wants to merge 1 commit into
Conversation
Commit 228775a removed the RouterError class when the router error codes joined the vocabulary, but left the name in __all__. A star import of lm15.router crashes: >>> from lm15.router import * AttributeError: module 'lm15.router' has no attribute 'RouterError' Add a regression test that every name in lm15.router.__all__ resolves.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lm15/router.py's__all__still listsRouterError, but the class was removed in 228775a ("router.py drops RouterError and the router code"). A star import of the module crashes:This removes the stale entry and adds a regression test asserting every name in
lm15.router.__all__resolves.Tests:
tests/test_router.pypasses (109 tests). The rest of the suite shows identical pre-existing conformance-fixture collection errors and failures with and without this change.