Skip to content

router: drop stale RouterError from lm15.router.__all__ #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
harshitgavita-07 wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −1
Open

router: drop stale RouterError from lm15.router.__all__ #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion lm15/router.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,6 @@
"CHAT_PRESET_ROUTES",
"Resolution",
"RouterConfig",
"RouterError",
"UnknownModelError",
"AmbiguousModelError",
"MissingCredentialError",
Expand Down
9 changes: 9 additions & 0 deletions tests/test_router.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,6 +555,15 @@ def test_router_surface_placement() -> None:
assert hasattr(router_mod, name), name


def test_router_module_all_resolves() -> None:
# Every name in lm15.router.__all__ must exist: a stale entry crashes
# `from lm15.router import *` with AttributeError.
import lm15.router as router_mod

for name in router_mod.__all__:
assert hasattr(router_mod, name), name


def test_router_error_codes_are_bare_nouns() -> None:
# Taxonomy convention: codes are bare nouns ('transport', 'provider',
# ...), never suffixed with '_error'.
Expand Down