fix(release): pin the tag goreleaser builds - #1
Merged
Conversation
Two tags on one commit make git describe ambiguous. Releasing v0.0.1 from a commit also tagged v0.0.1-alpha.2 built, pushed and signed the alpha, and the run then failed resolving a digest for an image it never made.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.0.1 release run built, pushed and signed
0.0.1-alpha.2instead: both tags sit on the same commit and goreleaser resolves the current tag withgit describe, which picks arbitrarily between them. The run then failed looking for a digest forghcr.io/loft-sh/semstat:0.0.1, an image it had never built.Setting
GORELEASER_CURRENT_TAGto the ref the workflow is running on removes the guess.Part of DEVOPS-1335.
Test plan
dockers_v2records oneDocker Imageartifact per tag, all sharing the manifest digest, so the digest step resolves once the right tag is used.