kit: Add support mobile applications in GPUI Kit - #3045
Merged
Conversation
Co-authored-by: Codex <codex@openai.com>
huacnlee
added a commit
to longbridge/gpui-mobile
that referenced
this pull request
Sep 11, 2026
## Summary Embed GPUI Kit's Markdown TextView in a Swift-owned UIKit window instead of letting GPUI create the iOS example's window. A child controller renders into `GPUITextView: UIView`; native Compact / Expanded controls exercise layout changes. The light English sample puts emphasis, quotes, nested lists, code, tables, and tasks on the first screen. Fix two startup failures exposed by the simulator: supply the UIKit display handle to wgpu 29, and retain the `run_embedded` application handle so native callbacks cannot outlive the GPUI app. Synchronize layout and redraw without implicit animations during size changes. Correct the Xcode static-library paths and build directory. Pins GPUI Kit to commit `7d9efcd2069f9eaa6eb3ba6345aac4aa7d87c9f7` from longbridge/gpui-kit#3045, so a sibling local checkout is not required. No crates are published. The embedding example supports one GPUI view for the application lifetime; independent destruction and multiple instances are not implemented. ## Test Plan - Passed `cargo check --manifest-path example/Cargo.toml --target aarch64-apple-ios-sim` with the pinned Git dependency. - Built the Swift app with Xcode for the iOS simulator and ran it on iPhone 17 Pro / iOS 26.5 using the same GPUI Kit source revision locally. - Verified light Markdown rendering, native controls, and Compact / Expanded resizing. - Passed `git diff --check` and `bash -n example/build.sh`. - Embedded scrolling needs manual verification: the automation tool emitted touch begin/end without move events. Transient resize jitter also needs visual confirmation. - No Android, physical-device, or performance testing performed. --------- Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com>
huacnlee
changed the title
Co-authored-by: Codex <codex@openai.com>
huacnlee
changed the title
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com>
huacnlee
enabled auto-merge (squash)
September 11, 2026 15:53
huacnlee
disabled auto-merge
September 11, 2026 15:58
huacnlee
added a commit
to longbridge/gpui-mobile
that referenced
this pull request
Sep 11, 2026
## Summary A released iOS touch currently leaves GPUI's synthetic mouse over the last control, keeping hover feedback active. Clear the pointer hit test and emit MouseExited after touch end/cancellation and momentum frames, while preserving the original position for click and scroll dispatch. Handle UIKit cancellation separately so it never commits a deferred tap or starts a momentum fling. Cancel an active scroll with TouchPhase::Cancelled. Update the example's GPUI Kit revision to include mobile tooltip suppression, tap-triggered HoverCard behavior, and the inline is_mobile helper from longbridge/gpui-kit#3045. ## Test Plan - Built the Swift-hosted iOS example for aarch64-apple-ios-sim. - Used a temporary simulator smoke view to check HoverCard opens on tap, remains open when its content is tapped, and closes on outside tap. - Checked a normal ghost button with a configured tooltip: no lingering hover background or tooltip after release. - Restored the original chat example and rebuilt it with the final Kit revision. - GPUI Kit regression tests cover desktop hover and mobile tap interaction. - UIKit cancellation was reviewed in code; no system-cancellation gesture was injected. Android was not changed or tested. No crates published. Co-authored-by: Codex <codex@openai.com>
huacnlee
added a commit
to longbridge/gpui-mobile
that referenced
this pull request
Sep 11, 2026
## Summary Update the example GPUI Kit dependency to merged main commit `84f57fdfcb4910623fb0bb7f795b077e249f9271` from longbridge/gpui-kit#3045. ## Test Plan - iOS simulator arm64: `cargo check --lib --target aarch64-apple-ios-sim` passed (existing unused-function warning). - Android arm64/API 31: `cargo ndk -t arm64-v8a --platform 31 check --lib` passed. - Both checks ran in the example directory. Co-authored-by: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Support GPUI Kit applications hosted by an external mobile platform. iOS and Android builds exclude the desktop/web platform selector dependency and exports while retaining GPUI and component initialization.
Expose
gpui_kit::is_mobile()as an inline const target check shared by Base. On iOS and Android, Base-managed tooltips ignore show requests and HoverCard opens/closes on tap, stays open when its content is tapped, and dismisses on an outside tap. Desktop hover behavior is preserved. Direct GPUI tooltip APIs and editor LSP hover remain outside these changes.Add English and Chinese
/docs/mobileguides for temporarygpui-pre-mobilepackaging, credited to the original community gpui-mobile project. Cover simulator setup, Swift UIView embedding, lifecycle and keyboard layout, touch interactions, platform checks, and integration limits; link installation and component docs.Test Plan