Repository navigation
Drop dependencies the addon doesn't use - #17
Merged
Merged
Conversation
Only @babel/helper-plugin-utils, @formatjs/ts-transformer and ember-cli-babel-plugin-helpers are required anywhere in the source. ember-cli-htmlbars is the one that hurts: as a dependency it gets instantiated as a nested addon, and its included() reads ember.absolutePaths.templateCompiler, which ember-source 7 no longer exposes, so the app build fails before any template is compiled.
The addon blueprint left devDependencies for a dummy app under
tests/dummy, which was never added, plus empty addon/ and app/ trees, a
config/environment.js returning {} and the .ember-cli generator config.
None of it is used by the node tests or the lint setup.
The transforms only rewrite to ember-intl/helpers/t, and to the intl service's t(). Both are still there in 8 and 9, so apps on either got a peer warning for nothing.
The fixture tests load it by name, but it was never a devDependency. Babel found it through pnpm's hidden hoisting, from ember-cli-babel deep in ember-intl's auto-installed peer tree, so any change there could break the tests.
This was referenced Oct 20, 2026
BlueCutOfficial
approved these changes
Oct 21, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First part of splitting up #16.
Only
@babel/helper-plugin-utils,@formatjs/ts-transformerandember-cli-babel-plugin-helpersare required anywhere.ember-cli-htmlbarsis the one that hurts: as a dependency it gets instantiated as a nested addon, and itsincluded()readsember.absolutePaths.templateCompiler, which ember-source 7 no longer has, so the app build fails.Also removes the dummy app scaffolding that was never used, accepts ember-intl 8 and 9 as peers, and declares
@babel/plugin-transform-typescript, which the fixture tests load but only found through pnpm's hidden hoisting.