Repository navigation
Conversation
It had no tests. These run it through babel-plugin-ember-template-compilation v2, which is what ember-cli-htmlbars uses, and pin down how it rewrites and which modules it treats as the app's.
babel-plugin-ember-template-compilation v4, which Embroider uses, sets neither env.meta.moduleName nor env.moduleName, only env.filename, so every template threw. Check all three, keeping the old precedence for the path that feeds the id pattern, so classic output is unchanged. The template tests now run against v4 as well as v2.
This was referenced Oct 20, 2026
aklkv
force-pushed
the
fix/template-plugin-embroider
branch
2 times, most recently
from
October 22, 2026 08:37
f9b1018 to
2514d65
Compare
aklkv
changed the title
Contributor
Author
|
I dropped the strict-mode commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of splitting up #16.
babel-plugin-ember-template-compilationv4, which Embroider uses, only setsenv.filename, so the template plugin threw on every template. It now checksfilenameas well as the module names, with the old precedence kept so classic output doesn't change.The template plugin had no tests. The first commit adds them against v2 (what ember-cli-htmlbars uses), and the fix runs them against v4 as well.