Drop issue links a reader of this repo cannot open - #16
Merged
Merged
Conversation
Seven comments ended with a pointer to an internal tracker. They arrived here by being carried over verbatim when this work moved, and they are the kind of reference that is worse than none: an external reader gets a link that 404s, and the repository it names is not this repository's to advertise. Nothing is lost by removing them. Every one was a trailing "see #N" on a comment that already explains the whole reasoning above it — why both opt-out variable names are honoured in the installers, why a response's headers have to be read before its body, why `--data-raw` would be the escape hatch if a text body ever needed one. The pointer was the least informative line in each. Two are reworded rather than truncated, where the sentence named the tracker as the moment something changed; they now say what is true instead of when it became true. 588 tests, both installer suites, fmt and clippy clean.
zmofei
approved these changes
Sep 15, 2026
zmofei
added a commit
that referenced
this pull request
Sep 15, 2026
Carries the path-parameter encoding fix (#15) that's been sitting on this branch since it was cut, along with the CI timeout fix (#14), the private-repo doc de-linking (#16) and update-check version validation (#18) — none of which had reached main. See CHANGELOG.md for what 0.2.1 actually changes user-facing behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seven comments ended with a pointer to an internal tracker. They arrived here by being carried over verbatim when this work moved, and they're the kind of reference that's worse than none: an external reader gets a link that 404s, and the repository it names isn't this repository's to advertise.
Nothing is lost by removing them. Every one was a trailing
see #Non a comment that already explains the whole reasoning above it — why both opt-out variable names are honoured in the installers, why a response's headers have to be read before its body, why--data-rawwould be the escape hatch if a text body ever needed one. The pointer was the least informative line in each.Two are reworded rather than truncated, where the sentence named the tracker as the moment something changed; they now say what is true instead of when it became true.
Files:
docs/commands.md,scripts/install.sh,scripts/install.ps1,scripts/test-install.sh,scripts/test-install.ps1,src/executor.rs.588 tests, both installer suites (
all cases passed/all good), fmt and clippy clean.Based on #13 so its Windows leg doesn't inherit the hang still on
main; GitHub will retarget this tomainwhen #13 merges.Not covered here
Seven commit messages already in
main's history carry the same reference. Those can't be fixed without rewriting merged history on a public repo's default branch, which is a bigger call than this PR — worth deciding before the repo goes public rather than after.