Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CODEOWNERS
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
* @mapbox/locationai
4 changes: 1 addition & 3 deletions docs/commands.md
Original file line number Diff line number Diff line change
Expand Up @@ -629,9 +629,7 @@ Two details worth knowing:
is just as partial there, and the API's own document cannot carry the fact
without an envelope this CLI has promised not to add — so a `-o json`
consumer reading stdout alone is unaffected, and one watching stderr is
told. There is no `--all` yet; following the pages is the caller's job,
and [#117](https://github.com/mapbox/mapbox-cli-private/issues/117) tracks
changing that.
told. There is no `--all` yet; following the pages is the caller's job.
- **`--id` searches the page it was given.** On a paginated listing a miss
means "not on this page", which is not the same as "does not exist", so
the error says which and how to look further:
Expand Down
2 changes: 1 addition & 1 deletion scripts/install.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@
# installers, which are fetched and run in one line with no release notes
# in front of the reader - and breaking an opt-out is the one change that
# must not happen quietly. So both work here, and the new name wins when
# both are set. See mapbox/mapbox-cli-private#140.
# both are set.
#
# Unset, empty or whitespace is a cleared variable. `0`, `f`, `false`, `n`,
# `no` and `off` are clap's false spellings, the same reading this script
Expand Down
2 changes: 1 addition & 1 deletion scripts/install.sh
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ INSTALL_SOURCE="${MAPBOX_CLI_INSTALL_SOURCE:-}"
# release notes in front of them — and breaking an opt-out is the one change
# that must not happen quietly. So both work here, the new name wins when both
# are set, and the old one keeps working for the Dockerfile the comment above
# describes. See mapbox/mapbox-cli-private#140.
# describes.
#
# Unset, empty, or whitespace: a cleared variable. `0`, `f`, `false`, `n`, `no`
# and `off` are clap's false spellings, so a `0` is someone declining the
Expand Down
3 changes: 1 addition & 2 deletions scripts/test-install.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -517,8 +517,7 @@ try {
Start-Case 'MAPBOX_CLI_NO_TELEMETRY is honoured, and outranks the old name'
New-CaseEnv 'telemetry-new-name'
$env:MAPBOX_CLI_INSTALL_SOURCE = 'dockerfile'
# The documented name, which the binary reads and this script did not until
# mapbox/mapbox-cli-private#140.
# The documented name, which the binary reads and this script honours too.
$env:MAPBOX_CLI_NO_TELEMETRY = '1'
[IO.File]::WriteAllText($RequestLog, '')
Invoke-Installer
Expand Down
3 changes: 1 addition & 2 deletions scripts/test-install.sh
Original file line number Diff line number Diff line change
Expand Up @@ -666,8 +666,7 @@ shim curl-recording curl
CURL_LOG="${CASE_DIR}/curl-args"
export MAPBOX_TEST_CURL_LOG="$CURL_LOG"

# The documented name, which the binary reads and this script did not until
# mapbox/mapbox-cli-private#140.
# The documented name, which the binary reads and this script honours too.
: >"$CURL_LOG"
export MAPBOX_CLI_NO_TELEMETRY=1
run_piped && status=0 || status=$?
Expand Down
5 changes: 2 additions & 3 deletions src/executor.rs
Original file line number Diff line number Diff line change
Expand Up @@ -398,8 +398,7 @@ pub fn request_id(headers: &reqwest::header::HeaderMap) -> Option<String> {
/// A struct rather than three reads at the call site because `bytes()`
/// consumes the response: whatever is not taken before it is unrecoverable.
/// Taking only `Content-Type` is what left paginated listings truncating
/// silently and left a 500 with nothing to quote to support
/// (mapbox/mapbox-cli-private#117).
/// silently and left a 500 with nothing to quote to support.
struct ResponseHeaders {
/// Decides whether the body is read as text or written as bytes.
content_type: String,
Expand Down Expand Up @@ -797,7 +796,7 @@ const STDIN_PATH: &str = "-";
/// literal `@` cannot be passed this way. It costs nothing here, because every
/// operation reachable with `--data` today sends JSON, and `@` is not valid
/// JSON. If a text body that could start with one is ever wired up, `--data-raw`
/// is the established escape hatch — see mapbox/mapbox-cli-private#118.
/// is the established escape hatch.
///
/// Read here rather than at send time so that a `--dry-run` validates the file
/// too. A dry run that skipped this would describe a request that could not
Expand Down