Repository navigation
Conversation
…dense structure strings
…d truncation regressions
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…ible passive indicators
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3245070eed
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
… and depth-limit warnings
…-inclusion per member
|
Addressed all three source-backed findings at |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a297b24c13
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Fixed the newly reported P2 on latest head |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2ed5668bb9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Fixed latest reviewer P2 at exact head |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 149f9821dc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…ed member identity
… native report tree
|
Fixed latest P2 on exact head |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Reproduced problem (actual operator screenshots, 2026-10-17)
The screenshot of ARStack's live GR_X_7SX85 Reports inspector shows dense one-line serialized MMS
{ {...}, 0, ..., unix-ms=... (q=0x3F)}values, tiny labels, every auxiliary RCB bit section expanded, and a scroll position that obscures the basic control-block/active data. The IEDScout reference shows readable, expandable hierarchical member data and clear process values. This is a GUI usability defect, not a transport/CI readiness question.Implementation
BrowserReportMemberProjection.hpp(same canonical report runtime and sharedMmsEngineeringEvidencetype decoder) to produce a bounded structured MMS hierarchy, preserving original member ordinal, exact full reference, struct/array/scalar type, and source value. Limit: 256 top-level report members; 192 additional child rows; 4 levels; bounded scalar text.falseor missing/failed value into a fabricated state.Regression
Existing native
ied_report_workspace_qanow asserts the live report frame carries typed rows and a synthetic direct test of structured values, legitimate Boolean false, valid Quality, failed Read, excessive child count, and truncated-identity fail-closed behavior. Browser convergence static guards enforce bounds and UI consumption; native Qt QML build/smoke/rendered flows run exact-head.Important scope limitation
MMS report structures do not intrinsically provide typed labels for positional children. This PR makes the real values readable without inventing stVal/origin/q/t. The next semantic parity milestone must bind each decoded nested child against the canonical, verified SCL FCDA type tree (source authority), so that IEDScout-style named descendants and their enum labels can be displayed honestly. CI success will not imply full visual/real-relay acceptance.