Repository navigation
Studio: compact field right-click menus with correct placement and no phantom header - #227
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c34b7eb2e9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| width: 212 | ||
| height: commandRows * 29 + dividerRows * 7 + 8 | ||
| width: 204 | ||
| height: commandRows * 30 + dividerRows * 7 + 8 |
There was a problem hiding this comment.
Reduce the rendered popup height instead of clearing title
For the Windows Popup.Item path, Qt renders menu contents as a ListView over contentModel; Menu.title is not a header in the popup itself (Qt Windows Menu.qml). Clearing the title therefore removes no vertical row, while this formula actually increases a four-command menu from 131px to 135px. The reported oversized popup remains or becomes taller, and the added test cannot detect that because it only searches source strings rather than opening and measuring the menu.
Useful? React with 👍 / 👎.
User-reported problem
Windows engineering preview field right-click popup occupies a bulky dark card with disproportionate blank space above tiny actions. The same UX appears in current/voltage magnitude and angle menus; mouse and Shift+F10 must work consistently.
Fix
Menu.title: it can reserve a header area in Qt Quick Controls even though the themed menu does not paint a header. Keep contextual channel identity separately viacontextLabelwithout extra visible chrome.No firmware, sample rate, timing, PTP, data model, Start workflow or Apply-to-board controls changed. Scope is source + Qt/Windows operator acceptance; actual Windows interactive screenshot remains to be verified after CI.
Source commit:
c34b7eb2e9d65609d20b516c3dc2c1441001d12b.