Skip to content

Studio: compact field right-click menus with correct placement and no phantom header #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
masarray merged 1 commit into from
Oct 17, 2026
Merged

Studio: compact field right-click menus with correct placement and no phantom header #227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions apps/arstack_studio/qml/SignalMatrix.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,12 +124,14 @@ Rectangle {
property real pendingMagnitude: mag
property real pendingPhase: angle

// The same placement/visibility semantics for mouse and keyboard.
// Clamp horizontally to the row rather than allowing a 250px
// popup to extend underneath the adjacent matrix.
// Align with the field edge, not the left side of the table.
// Clamp inside the owning matrix and open below the editor;
// keyboard Menu/Shift+F10 uses exactly the same placement.
function openFieldMenu(field, actionMenu) {
const at = signalRow.mapFromItem(field, 0, field.height)
actionMenu.popup(Math.max(6, Math.min(at.x, signalRow.width - actionMenu.width)), at.y)
const edge = signalRow.mapFromItem(field, field.width, field.height)
const x = Math.max(6, Math.min(edge.x - actionMenu.width,
signalRow.width - actionMenu.width - 6))
actionMenu.popup(x, edge.y + 3)
}

// Action-backed menu uses a single globally styled delegate.
Expand All @@ -139,7 +141,7 @@ Rectangle {
id: magnitudeMenu
theme: matrix.theme
uiFont: matrix.uiFont
title: "Magnitude · " + signalRow.sid
contextLabel: "Magnitude · " + signalRow.sid
commandRows: 4
Action {
text: "Zero · 0"
Expand Down Expand Up @@ -170,7 +172,7 @@ Rectangle {
id: phaseMenu
theme: matrix.theme
uiFont: matrix.uiFont
title: "Angle · " + signalRow.sid
contextLabel: "Angle · " + signalRow.sid
commandRows: 3
Action {
text: "Zero angle · 0°"
Expand Down
25 changes: 16 additions & 9 deletions apps/arstack_studio/qml/StudioActionMenu.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,17 @@ Menu {
id: actionMenu
property var theme
property string uiFont: "Inter"
// The native Menu.title reserves a heading area even when a dark
// custom menu delegate does not paint it. That produces the oversized
// blank top area visible in the previous Windows context popup.
// Keep context for accessibility/diagnostics without a title header.
property string contextLabel: ""
title: ""
property int commandRows: 4
property int dividerRows: 1
popupType: Popup.Item
width: 212
height: commandRows * 29 + dividerRows * 7 + 8
width: 204
height: commandRows * 30 + dividerRows * 7 + 8

@chatgpt-codex-connector chatgpt-codex-connector Bot Oct 17, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Reduce the rendered popup height instead of clearing title

For the Windows Popup.Item path, Qt renders menu contents as a ListView over contentModel; Menu.title is not a header in the popup itself (Qt Windows Menu.qml). Clearing the title therefore removes no vertical row, while this formula actually increases a four-command menu from 131px to 135px. The reported oversized popup remains or becomes taller, and the added test cannot detect that because it only searches source strings rather than opening and measuring the menu.

Useful? React with 👍 / 👎.

topPadding: 4
bottomPadding: 4
leftPadding: 4
Expand All @@ -22,20 +28,21 @@ Menu {
delegate: MenuItem {
id: actionItem
width: actionMenu.width - actionMenu.leftPadding - actionMenu.rightPadding
implicitHeight: 29
implicitHeight: 30
leftPadding: 8
rightPadding: 8
font.family: actionMenu.uiFont
font.pixelSize: 11
contentItem: RowLayout {
spacing: 7
spacing: 9
Image {
visible: actionItem.icon.source.toString().length > 0
source: actionItem.icon.source
sourceSize.width: 24
sourceSize.height: 24
Layout.preferredWidth: visible ? 15 : 0
Layout.preferredHeight: 15
sourceSize.width: 18
sourceSize.height: 18
Layout.preferredWidth: visible ? 16 : 0
Layout.preferredHeight: 16
fillMode: Image.PreserveAspectFit
opacity: actionItem.enabled ? 0.95 : 0.33
}
Text {
Expand All @@ -48,7 +55,7 @@ Menu {
}
}
background: Rectangle {
radius: 4
radius: 5
color: actionItem.highlighted ? actionMenu.theme.menuHover : "transparent"
border.width: actionItem.activeFocus ? 1 : 0
border.color: actionMenu.theme.accent
Expand Down
10 changes: 9 additions & 1 deletion apps/arstack_studio/tests/check_operator_workspace.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,15 @@ def main() -> None:
"context actions must stay compact, descriptive and grouped")
assert "implicitHeight: 65" in source("RibbonAction.qml")
assert 'hovered ? "#142334"' in source("RibbonAction.qml")
assert "width: 212" in menu and "commandRows * 29" in menu
require('title: ""' in menu and 'property string contextLabel: ""' in menu
and 'contextLabel: "Magnitude · "' in matrix
and 'contextLabel: "Angle · "' in matrix
and 'title: "Magnitude · "' not in matrix and 'title: "Angle · "' not in matrix,
"context menu must have no phantom native title/header blank space")
require("width: 204" in menu and "commandRows * 30" in menu
and "actionMenu.popup(x, edge.y + 3)" in matrix
and "signalRow.mapFromItem(field, field.width, field.height)" in matrix,
"context menu must align to the editor with compact deterministic geometry")
assert "text: \"Generated setpoint · not independent on-wire proof\"" not in preview
assert "No ESP32 board detected · Preview mode only" in main_qml
require("Layout.preferredHeight: 57" in main_qml
Expand Down
Loading