Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .github/workflows/test.yml-template
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
name: Test

on:
pull_request:
branches: [ master ]

jobs:
build:

runs-on: ubuntu-latest

strategy:
matrix:
node-version: [20.x]

steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- run: npm install
- run: npm test
9 changes: 5 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"license": "GPL-3.0",
"devDependencies": {
"@mate-academy/eslint-config": "latest",
"@mate-academy/scripts": "^1.8.6",
"@mate-academy/scripts": "^2.1.3",
"eslint": "^8.57.0",
"eslint-plugin-jest": "^28.6.0",
"eslint-plugin-node": "^11.1.0",
Expand Down
66 changes: 64 additions & 2 deletions src/arrayMethodSort.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,71 @@
* Implement method Sort
*/
function applyCustomSort() {
[].__proto__.sort2 = function(compareFunction) {
// write code here
[].__proto__.sort2 = function (compareFunction) {
if (
typeof compareFunction !== 'function' &&
compareFunction !== undefined
) {
throw new TypeError('Compare must be a function');
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional: the thrown TypeError message is fine functionally, but you might align it with the native message for clearer compatibility (this is not required by the task).

}

const defaultCompare = (a, b) => {
const A = String(a);
const B = String(b);

if (A < B) {
return -1;
}

if (A > B) {
return 1;
}

return 0;
};

const comparator =
compareFunction === undefined ? defaultCompare : compareFunction;

const len = this.length >>> 0;
const items = [];

for (let i = 0; i < len; i++) {
if (i in this) {
items.push({ val: this[i], idx: i });
}
}

for (let i = 0; i < items.length - 1; i++) {
for (let j = 0; j < items.length - 1 - i; j++) {
Comment on lines +42 to +43
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bubble sort is used here which satisfies the task. As a non-blocking improvement for large arrays, consider implementing a more efficient sort (e.g., quicksort/mergesort) to reduce complexity.

const r = comparator(items[j].val, items[j + 1].val);
const shouldSwap = r === 0 ? items[j].idx > items[j + 1].idx : r > 0;

if (shouldSwap) {
const tmp = items[j];

items[j] = items[j + 1];
items[j + 1] = tmp;
}
}
}

let k = 0;

for (; k < items.length; k++) {
this[k] = items[k].val;
}

for (let i = k; i < len; i++) {
if (i in this) {
delete this[i];
}
}

return this;
};
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The task requires implementing Array.prototype.sort using the predefined [].__proto__.sort2, but this file only defines sort2 and never assigns it to the built-in sort. Consider adding an assignment such as Array.prototype.sort = Array.prototype.sort2; (or Array.prototype.sort = [].__proto__.sort2;) after this line so the task requirement is satisfied.


[].__proto__.sort = [].__proto__.sort2;
}

module.exports = applyCustomSort;
Loading