Repository navigation
perf(embedding): initialize logical input and result payloads - #32
Merged
aunjgr merged 2 commits intoOct 13, 2026
Conversation
aunjgr
marked this pull request as ready for review
October 12, 2026 19:59
This was referenced Oct 12, 2026
This was referenced Oct 13, 2026
zuyu
pushed a commit
that referenced
this pull request
Oct 14, 2026
* docs(embedding): record logical payload initialization design * perf(embedding): initialize logical input and result payloads
zuyu
pushed a commit
that referenced
this pull request
Oct 21, 2026
* docs(embedding): record logical payload initialization design * perf(embedding): initialize logical input and result payloads
zuyu
pushed a commit
that referenced
this pull request
Oct 22, 2026
* docs(embedding): record logical payload initialization design * perf(embedding): initialize logical input and result payloads
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small selective MO reader batches currently clear every rounded pinned-pool block. A short payload therefore pays for clearing allocation padding that is never part of the public input or GPU upload.
Move initialization to input and result acquisition, clearing only the logical payload. Unwritten logical bytes and result-layout gaps remain zero; unused physical padding remains untouched. Physical blocks and descriptors retain their existing accounting and ownership. The shared initializer is internal and nonvirtual; the public C ABI is unchanged.
Refs matrixorigin/matrixone#28966 and matrixorigin/matrixone#28968. The consumer integration is matrixorigin/matrixone#30021. This PR is independent of the grouped-aggregation optimization.
Validation on the frozen MO Pixi provider, using isolated incremental builds over merged native
b953bb5a:EmptyKernelregistration; the clean unmodifiedb953bb5acontrol produces the same diagnostic. This is qualified control evidence, not a zero-error sanitizer claim.These native test builds do not constitute a guarded release SDK or public TPC-H qualification. After merge, #30021 will pin merged source and run fresh matched release correctness, resource, and performance campaigns.