Repository navigation
iPad only for real; build 4 - #17
Merged
Merged
Conversation
project.yml set TARGETED_DEVICE_FAMILY "2" project-wide, but XcodeGen's iOS preset puts "1,2" on the app target, which wins. Builds 2 and 3 were universal: App Store Connect asked for iPhone screenshots and the app would install on iPhones. The setting now sits on the target, with a test that the app declares UIDeviceFamily [2]. Build number 4, since 2 and 3 are uploaded. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mattonik
pushed a commit
that referenced
this pull request
Oct 2, 2026
PR #17 made the same fix on main: TARGETED_DEVICE_FAMILY "2" on the app target, DeviceFamilyTests and build 4. Where the two overlap, main's version is kept (project.yml, DeviceFamilyTests.swift). What this branch still adds is "2" on the PointerLockerTests and MouseLockPrototype targets, which XcodeGen's iOS preset otherwise makes universal too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W5tzx8GXgMz9DMzc5BF4ND
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds 2 and 3 were universal (
UIDeviceFamily[1, 2]), so App Store Connect asks for iPhone screenshots and the app would install on iPhones.Cause:
project.ymlsetsTARGETED_DEVICE_FAMILY: "2"project-wide, but XcodeGen's iOS preset puts"1,2"on the app target, and the target setting wins.Fix:
TARGETED_DEVICE_FAMILY: "2"on the PointerLocker target, with a comment explaining why it's needed there.DeviceFamilyTestschecks that the built app declares iPad only. It failed with[1, 2]before the fix.CURRENT_PROJECT_VERSION4, since builds 2 and 3 are already uploaded.Testing:
tools/test.sh: 100 Swift tests and both JS suites pass. The resolved Release setting is nowTARGETED_DEVICE_FAMILY = 2.After merging, archive and upload build 4 and select it on the 1.0 version. The iPhone screenshot slots then disappear.
🤖 Generated with Claude Code