Repository navigation
iPad only on the test and prototype targets too - #18
Merged
Merged
Conversation
project.yml set TARGETED_DEVICE_FAMILY "2" in the project's settings, but XcodeGen gives every iOS target TARGETED_DEVICE_FAMILY '1,2' as a target setting, and a target's own value wins. Uploaded builds therefore listed iPhone too, and App Store Connect asked for iPhone screenshots. Each target now sets "2" itself, and a test checks that the built app's UIDeviceFamily is [2]. Build 3 was uploaded with iPhone support, so this is build 4. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W5tzx8GXgMz9DMzc5BF4ND
PR #17 made the same fix on main: TARGETED_DEVICE_FAMILY "2" on the app target, DeviceFamilyTests and build 4. Where the two overlap, main's version is kept (project.yml, DeviceFamilyTests.swift). What this branch still adds is "2" on the PointerLockerTests and MouseLockPrototype targets, which XcodeGen's iOS preset otherwise makes universal too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W5tzx8GXgMz9DMzc5BF4ND
mattonik
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#17 already fixed the App Store problem on
main. It setTARGETED_DEVICE_FAMILY: "2"on the app target (XcodeGen's iOS preset otherwise makes it'1,2'), addedDeviceFamilyTestsand bumped to build 4. This PR started as the same fix, somainhas been merged in, keeping #17's version wherever the two overlapped.What this PR still changes
project.ymlgetsTARGETED_DEVICE_FAMILY: "2"on the two targets #17 left alone:Neither target ships to the App Store, so this is tidying, not a release fix. The app target, the project-wide setting, the test and build 4 are exactly as on
main.Checked
project.ymlparses, and all three targets, plus the project-wide setting, are"2". The build number is 4.DeviceFamilyTests(passed). It runs again on the merge.🤖 Generated with Claude Code
https://claude.ai/code/session_01W5tzx8GXgMz9DMzc5BF4ND