Skip to content

fix(client): entrypoint imports would race#1368

Draft
LeoMcA wants to merge 1 commit intomainfrom
client-entry-race
Draft

fix(client): entrypoint imports would race#1368
LeoMcA wants to merge 1 commit intomainfrom
client-entry-race

Conversation

@LeoMcA
Copy link
Copy Markdown
Member

@LeoMcA LeoMcA commented Mar 12, 2026

Noticed while fixing #1367.

If a hook imported from the client entry point would await at the top level, we'd skip over it and go and continue executing some other scripts.

That breaks an assumption I had held, and breaks l10n loading.

There may be some cases where we're ok with things racing: like scrolling to the current item in the sidebar while we load elements.

Opened as draft to see how bad this feels on a remote environment.

@github-actions
Copy link
Copy Markdown
Contributor

ebe633a was deployed to: https://fred-pr1368.review.mdn.allizom.net/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants