[MCC-1476011]Python Lib-Create Get_dataset_versions() function#30
Merged
Merged
Conversation
ibaig-mdsol
requested review from
afieraru-mdsol,
butsyk-mdsol,
dsilaghi-mdsol,
nmakarava-mdsol and
slingampalli-mdsol
May 13, 2026 13:31
butsyk-mdsol
approved these changes
May 13, 2026
afieraru-mdsol
approved these changes
May 13, 2026
There was a problem hiding this comment.
Pull request overview
This PR updates the Python DataConnect default service to return dataset versions sorted (newest first) when calling get_dataset_versions(), aligning with the stated acceptance criteria.
Changes:
- Sort
get_dataset_versions()results bydataset_versionin descending order. - Add a (currently commented-out) test stub intended to validate sorting behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
dataconnect/service/default.py |
Sorts returned dataset versions in descending order by dataset_version. |
tests/test_service_default.py |
Adds a commented-out test stub for the new sorting behavior (not runnable as-is). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dsilaghi-mdsol
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feature
Replace this line with Project title.MCC-1476011Checklist
git commit --amend --no-editcommand to reduce commit messages when making small file changes (like changing linespacing).tests/folder.doc/folder.Changes Summary
Replace this section with description of implementation. Should be written in imperative present tense. Summary should be short, but descriptive and highlight changes in the PR.Deployment Notes