Skip to content

[MCC-1476011]Python Lib-Create Get_dataset_versions() function#30

Merged
dsilaghi-mdsol merged 1 commit into
mainfrom
featMCC-1476011_dataset_versions_sorted
May 13, 2026
Merged

[MCC-1476011]Python Lib-Create Get_dataset_versions() function#30
dsilaghi-mdsol merged 1 commit into
mainfrom
featMCC-1476011_dataset_versions_sorted

Conversation

@ibaig-mdsol

Copy link
Copy Markdown
Contributor

feature

Checklist

  • Review the pull request to fix typos and ensure variable/function names are intuitive, etc.
  • Make sure the pull request does not have excessive number of unnecessary commits. Utilize the git commit --amend --no-edit command to reduce commit messages when making small file changes (like changing linespacing).
  • Make sure you have added unit tests for the code changes. Tests should be added in the tests/ folder.
  • Modify docs, if required. Add any new documentation in the doc/ folder.
  • Rebase on latest active development branch (develop/main).

Changes Summary

Replace this section with description of implementation. Should be written in imperative present tense. Summary should be short, but descriptive and highlight changes in the PR.

Deployment Notes

  • Returns sorted per AC:

AC 2: It must return a list of all versions, accociated with this dataset, sorted by most recent first.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Python DataConnect default service to return dataset versions sorted (newest first) when calling get_dataset_versions(), aligning with the stated acceptance criteria.

Changes:

  • Sort get_dataset_versions() results by dataset_version in descending order.
  • Add a (currently commented-out) test stub intended to validate sorting behavior.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
dataconnect/service/default.py Sorts returned dataset versions in descending order by dataset_version.
tests/test_service_default.py Adds a commented-out test stub for the new sorting behavior (not runnable as-is).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread dataconnect/service/default.py
Comment thread tests/test_service_default.py
@dsilaghi-mdsol
dsilaghi-mdsol merged commit 3ec0ea7 into main May 13, 2026
7 checks passed
@ibaig-mdsol
ibaig-mdsol deleted the featMCC-1476011_dataset_versions_sorted branch June 8, 2026 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants