Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion dataconnect/service/default.py
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,13 @@ def get_dataset_versions(self, dataset_uuid: UUID) -> list[DatasetVersion]:

try:
resources = self._transport.list_resources(request)
return [resource_to_dataset_version(r) for r in resources]

# Return Sorted dataset versions in descending order (newest first) based on the dataset_version field.
return sorted(
(resource_to_dataset_version(r) for r in resources),
key=lambda dv: dv.dataset_version,
reverse=True,
)
Comment thread
ibaig-mdsol marked this conversation as resolved.
except Exception as ex:
raise translate_error(ex) from ex

Expand Down
11 changes: 11 additions & 0 deletions tests/test_service_default.py
Original file line number Diff line number Diff line change
Expand Up @@ -75,3 +75,14 @@
# assert len(studies) == 1
# assert transport.last_request is not None
# assert transport.last_request.body == ""

# def test_get_dataset_versions_sorted(monkeypatch):
# service = DefaultDataConnectService(transport=DummyTransport())
# # Patch the mapping function to our dummy
# monkeypatch.setattr(
# "dataconnect.service.default.resource_to_dataset_version",
# dummy_resource_to_dataset_version,
# )
# result = service.get_dataset_versions(UUID("073410b6-79be-3e7d-ae37-92f6e054013e"))
# versions = [dv.dataset_version for dv in result]
# assert versions == sorted(versions, reverse=True)
Comment thread
ibaig-mdsol marked this conversation as resolved.
Loading