Update to latest nightly, nightly-2023-05-10#249
Merged
Conversation
kkysen
force-pushed
the
kkysen/update-to-latest-nightly
branch
2 times, most recently
from
63512d3 to
df2158b
Compare
randomPoison
approved these changes
May 23, 2023
`#![feature(let_chains)]` became unstable again as it was implemented incorrectly, so I've removed their few uses and manually desugared them or used `Option::filter` instead.
kkysen
force-pushed
the
kkysen/update-to-latest-nightly
branch
from
df2158b to
7593d2e
Compare
…d arch. `Align1` is used when alignment wasn't specified in C to avoid have to `cfg` the uses of `scaling`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are some newly stabilized things that we want to use to replace C versions.
ilog2from #184 and other cleanups was one of them, and there were some other ones I came across as well.Also,
#![feature(let_chains)]became unstable again as it was implemented incorrectly, so I've removed their few uses and manually desugared them or usedOption::filterinstead.Also, upgrading the toolchain seems to cause test failures now because of stricter checks. Raw pointer dereferences are now checked for alignment (in debug builds it seems), and that's now uncovering further errors. Unaligned references are UB in Rust, so we need to fix these. Tracked in #250. This is another great reason to upgrade the toolchain, as this is a really useful check.
Update: #251 has been merged into this PR, fixing the crashes explained above.