Repository navigation
Fix armed macro capture in Copilot bypass mode - #3214
Merged
George Ng (GeorgeNgMsft) merged 2 commits intoOct 24, 2026
Merged
Conversation
Claim explicitly selected recordings before bypassing recipe matching. Keep recipe-off, recording feature flags, Copilot task ownership, and success-receipt checks intact. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0040b8ff-2701-4fb7-821f-760e05fe6b4b
Hillary Mutisya (hillary-mutisya)
approved these changes
Oct 24, 2026
Update the bypass mode assertion to expect recording checks, preserve silent no-host behavior, and verify malformed endpoint diagnostics remain visible. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0040b8ff-2701-4fb7-821f-760e05fe6b4b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
An explicitly armed macro recording can now be claimed while TypeAgent routing is in bypass mode. The task stays with Copilot; bypass still prevents recipe matching/execution, and TypeAgent MCP calls remain disabled.
Previously, the hook returned for bypass before it tried to claim a recording. The token stayed armed, so the session observer never finalized the selected interaction.
The change keeps recipe-owner
off, recording feature flags, and the existing success-receipt checks intact. Regression tests cover claimed recordings, child-learning receipts, recipe-off behavior in all four modes, and unclaimed bypass requests. The README explains how to capture native or third-party MCP calls without routing the task to TypeAgent.Validation
pnpm exec fluid-build @typeagent/copilot-plugin -t build --dep.A live recording/learning/replay with an updated installed plugin was not performed. These checks do not establish full end-to-end macro creation or replay.
Earlier macro findings considered
The previously observed MSI runtime-cache lookup and dispatcher SDK-runtime selection issues remain separate installer/reasoning concerns. Current macro authoring is plugin-owned and uses Copilot child agents, so those changes are not needed for this hook fix and are not bundled here.
The earlier confirmation-continuation cancellations still have no confirmed root cause. This PR does not make speculative changes to confirmation or permission handling.