Repository navigation
Allow users to revise macros before publishing - #3238
Open
George Ng (GeorgeNgMsft) wants to merge 2 commits into
Open
George Ng (GeorgeNgMsft) wants to merge 2 commits into
George Ng (GeorgeNgMsft) wants to merge 2 commits into
Conversation
Add checked, immutable draft revisions with plain-language feedback, job tracking, and explicit approval. Preserve recording provenance and validate corrected outputs independently before publication. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Git-Story: - cece3bbc3ceb3f157b172d12f280b65f6e4bc07162d3c5afe32e6a394ca6618d#1 apply_patch ts/packages/copilot-macros/src/contracts.ts ts/packages/copilot-macros/src/macroLearning.ts ts/packages/copilot-macros/src/macroManager.ts ts/packages/copilot-macros/src/macroProgramAuthoring.ts - cece3bbc3ceb3f157b172d12f280b65f6e4bc07162d3c5afe32e6a394ca6618d#2 apply_patch ts/packages/copilot-macros/src/macroLearning.ts ts/packages/copilot-plugin/src/extension/local-recipe-service.ts ts/packages/copilot-plugin/src/mcp/macroServer.ts ts/packages/copilot-plugin/src/shared/macro-owner.ts ts/packages/copilot-plugin/src/shared/mcp-guidance.ts ts/packages/copilot-plugin/src/shared/recipe-commands.ts - cece3bbc3ceb3f157b172d12f280b65f6e4bc07162d3c5afe32e6a394ca6618d#3 apply_patch ts/packages/copilot-macros/test/macroChildLearning.spec.ts - cece3bbc3ceb3f157b172d12f280b65f6e4bc07162d3c5afe32e6a394ca6618d#4 apply_patch ts/packages/copilot-macros/test/macroChildLearning.spec.ts ts/packages/copilot-macros/test/macroAuthoringRuntime.spec.ts ts/packages/copilot-plugin/test/localRecipeService.spec.ts ts/packages/copilot-plugin/test/macroServer.spec.ts ts/packages/copilot-plugin/test/pluginArtifact.spec.ts ts/packages/copilot-plugin/test/recipeCommands.spec.ts - cece3bbc3ceb3f157b172d12f280b65f6e4bc07162d3c5afe32e6a394ca6618d#5 apply_patch ts/docs/architecture/workflows/macros.md ts/packages/copilot-macros/README.md ts/packages/copilot-plugin/README.md ts/packages/copilot-plugin/skills/typeagent-macros/SKILL.md - cece3bbc3ceb3f157b172d12f280b65f6e4bc07162d3c5afe32e6a394ca6618d#6 apply_patch ts/packages/copilot-macros/test/macroChildLearning.spec.ts - cece3bbc3ceb3f157b172d12f280b65f6e4bc07162d3c5afe32e6a394ca6618d#7 powershell ts/packages/copilot-macros/src/macroLearning.ts ts/packages/copilot-macros/test/macroAuthoringRuntime.spec.ts ts/packages/copilot-macros/test/macroChildLearning.spec.ts - cece3bbc3ceb3f157b172d12f280b65f6e4bc07162d3c5afe32e6a394ca6618d#8 vote_memory ts/packages/copilot-plugin/test/macroServer.spec.ts ts/packages/copilot-plugin/test/recipeCommands.spec.ts - cece3bbc3ceb3f157b172d12f280b65f6e4bc07162d3c5afe32e6a394ca6618d#9 apply_patch ts/docs/architecture/workflows/macros.md ts/packages/copilot-macros/src/macroLearning.ts ts/packages/copilot-plugin/README.md ts/packages/copilot-plugin/src/shared/recipe-commands.ts ts/packages/copilot-plugin/test/recipeCommands.spec.ts - cece3bbc3ceb3f157b172d12f280b65f6e4bc07162d3c5afe32e6a394ca6618d#10 powershell ts/packages/copilot-macros/src/macroLearning.ts ts/packages/copilot-plugin/src/shared/recipe-commands.ts
Keep run, revision, inspection and publication commands on the same positive-safe-integer validation path and stay within the command complexity budget. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Git-Story: - cece3bbc3ceb3f157b172d12f280b65f6e4bc07162d3c5afe32e6a394ca6618d#11 apply_patch ts/packages/copilot-plugin/src/shared/recipe-commands.ts
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Users can now describe corrections to a captured macro during publish review instead of accepting an incorrect draft or recording the task again.
revise_macrowith an exact current draft version and plain-language feedback, plusget_macro_learning_jobto track the revised draft.@typeagent recipe revise <macroId> <version> <feedback>and@typeagent recipe status <jobId>.Revised drafts always stop for explicit review and approval, including under Read-only or All. Starting a revision blocks approval of the old draft. Unsupported changes fail explicitly; this does not add tools, authorize effects, weaken capability checks, or execute the recorded task during authoring.
Example
During review, ask: “Return only the title, not the entire tool response.”
Copilot calls
revise_macrowith the current draft reference and that feedback. Once the returned job reachesneedsReview, the user can inspect the new version, request another correction, or approve that exact version.Validation