Skip to content

[dotnet-code] Consolidate workflow edge registration#352

Merged
qmuntal merged 2 commits into
mainfrom
dotnet-code/workflow-edge-registration-a35e83ce8fd245b9
Jun 25, 2026
Merged

[dotnet-code] Consolidate workflow edge registration#352
qmuntal merged 2 commits into
mainfrom
dotnet-code/workflow-edge-registration-a35e83ce8fd245b9

Conversation

@michelle-clayton-work

Copy link
Copy Markdown
Contributor

Centralize workflow builder edge insertion behind an unexported helper so direct, fan-out, and fan-in edge paths share the same internal registration shape.

Centralize workflow builder edge insertion behind an unexported helper so direct, fan-out, and fan-in edge paths share the same internal registration shape.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings June 24, 2026 18:45
@michelle-clayton-work
michelle-clayton-work requested a review from a team as a code owner June 24, 2026 18:45

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the workflow Builder to centralize edge registration into a single unexported helper, so direct, fan-out, and fan-in edge creation paths all insert edges into the internal edges map consistently.

Changes:

  • Replaced direct wb.edges[sourceID] = append(...) writes with a shared addEdgeForSource helper.
  • Added the unexported addEdgeForSource(sourceID string, edge Edge) method to consolidate insertion logic across edge-building methods.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown
Contributor

Cross-Repo API Consistency Review

Result: ✅ No parity issues — out of scope for cross-repo consistency review.

This PR extracts one repeated internal map-append pattern into an unexported helper method (addEdgeForSource). The three public Builder methods that call it — AddDirectEdge, AddFanOutEdge, and AddFanInBarrierEdge — are unchanged in signature, semantics, and observable behavior.

Because the change is a pure internal refactor with no effect on exported Go APIs, defaults, or runtime behavior, there is nothing to compare against the upstream .NET or Python implementations.

Generated by Go API Consistency Review Agent for issue #352 · 28.5 AIC · ⌖ 12.4 AIC · ⊞ 26.8K ·

@qmuntal
qmuntal added this pull request to the merge queue Jun 25, 2026
@qmuntal qmuntal linked an issue Jun 25, 2026 that may be closed by this pull request
@qmuntal
qmuntal removed this pull request from the merge queue due to a manual request Jun 25, 2026
@qmuntal
qmuntal added this pull request to the merge queue Jun 25, 2026
Merged via the queue into main with commit 8186177 Jun 25, 2026
18 checks passed
@qmuntal
qmuntal deleted the dotnet-code/workflow-edge-registration-a35e83ce8fd245b9 branch June 25, 2026 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[dotnet-code] Consolidate workflow edge registration

3 participants