[dotnet-code] Consolidate workflow edge registration#352
Conversation
Centralize workflow builder edge insertion behind an unexported helper so direct, fan-out, and fan-in edge paths share the same internal registration shape. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR refactors the workflow Builder to centralize edge registration into a single unexported helper, so direct, fan-out, and fan-in edge creation paths all insert edges into the internal edges map consistently.
Changes:
- Replaced direct
wb.edges[sourceID] = append(...)writes with a sharedaddEdgeForSourcehelper. - Added the unexported
addEdgeForSource(sourceID string, edge Edge)method to consolidate insertion logic across edge-building methods.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This comment has been minimized.
This comment has been minimized.
Cross-Repo API Consistency ReviewResult: ✅ No parity issues — out of scope for cross-repo consistency review. This PR extracts one repeated internal map-append pattern into an unexported helper method ( Because the change is a pure internal refactor with no effect on exported Go APIs, defaults, or runtime behavior, there is nothing to compare against the upstream .NET or Python implementations.
|
Centralize workflow builder edge insertion behind an unexported helper so direct, fan-out, and fan-in edge paths share the same internal registration shape.